Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event logger #1480

Draft
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

remove Logger.EmitEvent

f25fda3
Select commit
Loading
Failed to load commit list.
Draft

Remove event logger #1480

remove Logger.EmitEvent
f25fda3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 1s

72.12% (-0.08%) compared to 145b87f, passed because coverage increased by 0.01% when compared to adjusted base (72.11%)

View this Pull Request on Codecov

72.12% (-0.08%) compared to 145b87f, passed because coverage increased by 0.01% when compared to adjusted base (72.11%)

Details

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (145b87f) to head (f25fda3).

Files with missing lines Patch % Lines
src/API/Logs/LogRecord.php 0.00% 3 Missing ⚠️
src/SDK/Logs/ReadableLogRecord.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1480      +/-   ##
============================================
- Coverage     72.20%   72.12%   -0.08%     
+ Complexity     2730     2713      -17     
============================================
  Files           401      395       -6     
  Lines          8152     8091      -61     
============================================
- Hits           5886     5836      -50     
+ Misses         2266     2255      -11     
Files with missing lines Coverage Δ
src/API/Globals.php 100.00% <100.00%> (ø)
src/API/Instrumentation/CachedInstrumentation.php 100.00% <ø> (ø)
src/API/Instrumentation/Configurator.php 100.00% <ø> (ø)
src/API/Instrumentation/ContextKeys.php 100.00% <ø> (ø)
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% <ø> (ø)
src/Contrib/Otlp/LogsConverter.php 93.75% <100.00%> (+0.24%) ⬆️
src/SDK/Logs/Exporter/ConsoleExporter.php 100.00% <100.00%> (ø)
src/SDK/Sdk.php 100.00% <ø> (ø)
src/SDK/SdkAutoloader.php 93.75% <ø> (-0.17%) ⬇️
src/SDK/SdkBuilder.php 100.00% <ø> (ø)
... and 2 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145b87f...f25fda3. Read the comment docs.