Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml config env var spec conformance #1486

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 23, 2025

Updating env var substitution to conform to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.41.0/specification/configuration/data-model.md#environment-variable-substitution

  • env: prefix allowed in environment variable
  • do not recursively apply env var substitution (ie don't allow env vars in env vars)

@brettmc brettmc requested a review from a team as a code owner January 23, 2025 23:49
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (7eb3abb) to head (162f22e).

Files with missing lines Patch % Lines
...guration/Internal/EnvSubstitutionNormalization.php 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1486      +/-   ##
============================================
+ Coverage     70.71%   70.83%   +0.11%     
  Complexity     2761     2761              
============================================
  Files           408      408              
  Lines          8341     8341              
============================================
+ Hits           5898     5908      +10     
+ Misses         2443     2433      -10     
Flag Coverage Δ
8.1 70.45% <0.00%> (+0.01%) ⬆️
8.2 70.66% <0.00%> (+0.09%) ⬆️
8.3 70.66% <0.00%> (+0.01%) ⬆️
8.4 70.62% <0.00%> (+0.04%) ⬆️
8.5 70.69% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...guration/Internal/EnvSubstitutionNormalization.php 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb3abb...162f22e. Read the comment docs.

- fix env substitution normalization so that it doesn't apply 2 replacement normalizers for string nodes
@brettmc brettmc changed the title add support for env: prefix in yaml config add support for env: prefix in yaml config, fix recursive env var replace Jan 24, 2025
@brettmc brettmc changed the title add support for env: prefix in yaml config, fix recursive env var replace yaml config env var spec conformance Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants