Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new fields for SQLCommenter:
"application"
, which should contain the name of the application"action"
, which should contain the HTTP verb in the requestBoth are documented in the spec for SQLCommenter, and (for example) both are accepted by Google Cloud when displaying Query Insights.
Note that
"app_name"
is already included, but"application"
is the field expected in the spec.Open questions:
app_name
field? I can't see this one described in the spec.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested by:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.