-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
botocore: add basic tracing for bedrock ConverseStream #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Jan 23, 2025
...trumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock_utils.py
Outdated
Show resolved
Hide resolved
xrmx
commented
Jan 23, 2025
...etry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/types.py
Outdated
Show resolved
Hide resolved
codefromthecrypt
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you mind checking if this langchain code produces spans as intended?
from langchain_aws import ChatBedrock
def main():
llm = ChatBedrock(
beta_use_converse_api=True,
model_id='amazon.titan-text-lite-v1',
streaming=True,
)
response_stream = llm.stream("Write a short poem on OpenTelemetry.")
for chunk in response_stream:
for item in chunk.content:
if 'text' in item:
print(item['text'], end="")
if __name__ == "__main__":
main()
It does:
|
xrmx
force-pushed
the
bedrock-converse-stream
branch
from
January 24, 2025 08:52
5241f21
to
9af5b68
Compare
github-actions
bot
assigned lmolkova, lzchen, nemoshlag, nikosokolik, nirga and oxeye-nikolay
Jan 24, 2025
xrmx
force-pushed
the
bedrock-converse-stream
branch
from
January 24, 2025 08:53
9af5b68
to
bd8a50f
Compare
11 tasks
lmolkova
reviewed
Jan 25, 2025
...trumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock_utils.py
Show resolved
Hide resolved
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces basic tracing for the ConverseStream service. I've chosen to delay the closing of the span after the response has been consumed instead of buffering all the response chunks since the buffer may become big.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.