DRAFT: Add configuration of log level and formatting for Auto Instrumentation #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
changed the title
jeremydvoss
force-pushed
the
auto-format
branch
from
4b0e27a to
a0b79f8
Compare
jeremydvoss
force-pushed
the
auto-format
branch
from
a0b79f8 to
e641e75
Compare
xrmx
reviewed
Oct 8, 2024
jeremydvoss
commented
Jan 30, 2025
| levels = { | ||
| "debug": logging.DEBUG, | ||
| "info": logging.INFO, | ||
| "warning": logging.WARNING, |
|
According to the specification, The logging config should only apply to the |
| logging.getLogger().addHandler(handler) | ||
| logging.basicConfig( | ||
| format=log_format, | ||
| level=log_level, |
There was a problem hiding this comment.
This will have the side effect of applying to all loggers without custom levels. The root here should be logging.NOSET and afterwards add logging.getLogger('opentelemetry').setLevel(log_level) to allow the OTEL_LOG_LEVEL to only apply to the SDK and instrumentors and exporters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DRAFT: Proposal for adding configuration of log level and formatting for Auto Instrumentation. Main subject to decide on is which env vars to use:
OTEL_LOG_LEVEL: Exists in the SDK but unused
OTEL_PYTHON_LOG_LEVEL: Currently only used by Python Logging Instrumentation
OTEL_PYTHON_LOG_FORMAT: Currently only used by Python Logging Instrumentation
Fixes #4034
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: