fix: AtomicI64, AtomicU64 for build mipsel processor #2301
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 123 123
Lines 21263 21263
=====================================
+ Hits 16938 16940 +2
+ Misses 4325 4323 -2 ☔ View full report in Codecov by Sentry. |
|
ref: #2054 |
TGLuong
changed the title
TGLuong
changed the title
cijothomas
reviewed
Nov 19, 2024
| @@ -18,6 +18,12 @@ pub(crate) use exponential_histogram::{EXPO_MAX_SCALE, EXPO_MIN_SCALE}; | |||
| use once_cell::sync::Lazy; | |||
| use opentelemetry::{otel_warn, KeyValue}; | |||
|
|
|||
| #[cfg(any(target_arch = "mips", target_arch = "powerpc"))] | |||
| use portable_atomic::{AtomicBool, AtomicI64, AtomicU64, AtomicUsize}; | |||
There was a problem hiding this comment.
are these the only place this SDK uses Atomics?
|
could you add this for xtensa arch too? I'm trying to use this sdk on ESP32 and getting this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
AtomicI64,AtomicU64in std.Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes