feat: Replace Zipkin pipeline with exporter builders #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
=======================================
+ Coverage 77.8% 79.7% +1.8%
=======================================
Files 122 118 -4
Lines 23061 22464 -597
=======================================
- Hits 17956 17909 -47
+ Misses 5105 4555 -550 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jan 25, 2025
cijothomas
reviewed
Jan 25, 2025
cijothomas
reviewed
Jan 25, 2025
| @@ -3,6 +3,7 @@ | |||
| ## vNext | |||
|
|
|||
| - Bump msrv to 1.75.0. | |||
| - **Breaking** The `opentelemetry_zipkin::new_pipeline()` interface is now replaced with `opentelemetry_zipkin::ZipkinExporter::builder()`. | |||
There was a problem hiding this comment.
can you modify the PR description or the changelog itself to show before/after to help migration?
There was a problem hiding this comment.
please have a look, if the example is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2473
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes