Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add User-agent OS attributes #1434

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

rogercoll
Copy link
Contributor

Fixes #1433

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@rogercoll
Copy link
Contributor Author

The PR is mostly a copy and paste from the OS attributes current definition to the user_agent's attributes, is there a way to reference them but applying the "user_agent" prefix?

@rogercoll rogercoll marked this pull request as ready for review October 1, 2024 07:33
@rogercoll rogercoll requested review from a team as code owners October 1, 2024 07:33
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 18, 2024
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 22, 2024
@github-actions github-actions bot removed the Stale label Dec 25, 2024
Copy link

github-actions bot commented Jan 9, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 9, 2025
@github-actions github-actions bot removed the Stale label Jan 10, 2025
@rogercoll rogercoll self-assigned this Jan 15, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a straightforward embedding of os.name and os.version under the user_agent.* namespace 👍

.chloggen/user_agent_os.yaml Outdated Show resolved Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Copy link
Contributor

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might revisit these attributes when embediing will be there to re-use os.* attributes

@trask
Copy link
Member

trask commented Jan 29, 2025

I think we might revisit these attributes when embediing will be there to re-use os.* attributes

that will just be a mechanical change? or do you think that would change (break) the semantics of these new attributes?

@trisch-me
Copy link
Contributor

trisch-me commented Jan 29, 2025

from my POV one of the goals of embedding - not to break semantics of fields itself, but adding additional meaning.
In this particular case os.* attributes will be attached to the user agent hence additional meaning. But this is what we are already having while introducing these fields so I don’t see any problems

@trask
Copy link
Member

trask commented Jan 29, 2025

@rogercoll sorry, one more thing, can you describe how you are using these attributes? e.g. are you enriching existing spans that already have user_agent.original? or emitting events, or other spans using them? thanks!

based on how you're using them, we can consider if we would like to add them to one of those signals in semconv, e.g. as an opt-in attribute on http spans

@rogercoll
Copy link
Contributor Author

@rogercoll sorry, one more thing, can you describe how you are using these attributes? e.g. are you enriching existing spans that already have user_agent.original? or emitting events, or other spans using them? thanks!

based on how you're using them, we can consider if we would like to add them to one of those signals in semconv, e.g. as an opt-in attribute on http spans

Not enriching spans at the moment, but enriching logs that contain an unparsed user_agent. Specifically, the Nginx Ingress Controller structured logs in which we extract the corresponding fields using OpenTelemetry Collector's processors (OTTL). Although the Nginx Ingress Controlled Log Event PR is in a draft state, we would like to include the log attributes containing this user_agent.os* values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:user-agent enhancement New feature or request
Projects
Status: Needs More Approval
Development

Successfully merging this pull request may close these issues.

Add User Agent OS attributes
6 participants