-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add User-agent OS attributes #1434
base: main
Are you sure you want to change the base?
Conversation
The PR is mostly a copy and paste from the OS attributes current definition to the user_agent's attributes, is there a way to reference them but applying the "user_agent" prefix? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a straightforward embedding of os.name
and os.version
under the user_agent.*
namespace 👍
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might revisit these attributes when embediing will be there to re-use os.*
attributes
that will just be a mechanical change? or do you think that would change (break) the semantics of these new attributes? |
from my POV one of the goals of embedding - not to break semantics of fields itself, but adding additional meaning. |
@rogercoll sorry, one more thing, can you describe how you are using these attributes? e.g. are you enriching existing spans that already have based on how you're using them, we can consider if we would like to add them to one of those signals in semconv, e.g. as an opt-in attribute on http spans |
Not enriching spans at the moment, but enriching logs that contain an unparsed user_agent. Specifically, the Nginx Ingress Controller structured logs in which we extract the corresponding fields using OpenTelemetry Collector's processors (OTTL). Although the Nginx Ingress Controlled Log Event PR is in a draft state, we would like to include the log attributes containing this |
Fixes #1433
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]