Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #1814

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Fix links #1814

merged 4 commits into from
Jan 27, 2025

Conversation

trask
Copy link
Member

@trask trask commented Jan 24, 2025

Link checker isn't checking anchors on external links, I've opened #1813 to look into (and hopefully fix) the underlying issue in lychee, but fixing the links @chalin has found via the website link checker in the meantime...

@trask trask added the Skip Changelog Label to skip the changelog check label Jan 24, 2025
@trask trask requested review from a team and tigrannajaryan as code owners January 24, 2025 20:10
docs/gen-ai/gen-ai-events.md Outdated Show resolved Hide resolved
docs/general/events.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Jan 24, 2025

Note that the patching done via

Is minimal to ensure that the link checker is happy. I haven't matched all the changes proposed in this PR. (Probably what you already expect, but wanted to make that explicit.)

trask and others added 2 commits January 27, 2025 07:39
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@joaopgrassi
Copy link
Member

The link check failure is fixed in #1825

@joaopgrassi joaopgrassi merged commit 736f859 into open-telemetry:main Jan 27, 2025
13 of 14 checks passed
@trask trask deleted the fix-links branch January 27, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants