-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editorial] Hugo front matter title and other fixes #1820
[editorial] Hugo front matter title and other fixes #1820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I'm happy to defer to maintainers on the styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! I left a few questions I wasn't sure about.
ee52d01
to
4afa447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
I left a few non-blocking suggestions if they make sense
88ce8ba
to
b2e7539
Compare
b2e7539
to
118d137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this!
I hope we could do better in semconv and either automate or at least catch some of these during review.
A few things that could help:
-
Is there a crash course on hugo (in the context of otel.io)? E.g.
- we have
<!--- Hugo front matter used to generate the website version of this page: --->
in some cases we have it in some other cases we don't - why? - Is there a good link we could add to contributing.md to help contributors with incantations like
path_base_for_github_subdir
? - How to rename/move files keeping website links
- we have
-
Could we come up with some guidance on how to do things in semconv?
E.g.linkTitle
is a short thing that does not include semconv name, just the sub-area within it. It should usually beSpans
,Metrics
,Resources
, etc. It's in 'Sentence case'- Headings should use 'Title Case' (TBH I'd default to `Sentence case' everywhere)
I'm happy to follow up on this, but would probably need help with Hugo part
@chalin do you think we need to fix our CI check to accommodate this change? if so, is it possible to split that out into a separate issue so we can go ahead and merge this PR?
|
Yes, done. |
@lmolkova - sentence case is my preference as well, and what Google recommends in it's style guide, see Headings:
I'd like to land this PR. I can switch to title case if you prefer in a followup PR. In this way both title and link-title will match in their use of letter case. Let me know what you think. As for your other questions, I'll need to get back to you. Maybe we can track that via a separate issue. (Edit: short answer is that we can certainly document conventions and actually automate some checks.) |
**...**
bolding from one of the titles.path_base_for_github_subdir
to ensure that OTel.io users can navigate to the page source<!--- Hugo front matter ... --->
comments/cc @trask @open-telemetry/docs-maintainers