Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix broken SQL Where Wikipedia link #1825

Merged
merged 4 commits into from
Jan 27, 2025
Merged

[chore] Fix broken SQL Where Wikipedia link #1825

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21591b6
Fix broken Wikipedia link
joaopgrassi Jan 27, 2025
566fe27
Merge branch 'main' into fix-wiki-sql-where-link
joaopgrassi Jan 27, 2025
5b4d0cd
Merge branch 'main' into fix-wiki-sql-where-link
joaopgrassi Jan 27, 2025
e6c123f
Merge branch 'main' into fix-wiki-sql-where-link
joaopgrassi Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/database/database-spans.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ in which case the instrumentation MAY choose a different placeholder.

Placeholders in a parameterized query SHOULD not be sanitized. E.g. `where id = $1` can be captured as is.

[IN-clauses](https://wikipedia.org/wiki/Where_(SQL)#IN) MAY be collapsed during sanitization,
[IN-clauses](https://wikipedia.org/wiki/SQL_syntax#Operators) MAY be collapsed during sanitization,
e.g. from `IN (?, ?, ?, ?)` to `IN (?)`, as this can help with extremely long IN-clauses,
and can help control cardinality for users who choose to (optionally) add `db.query.text` to their metric attributes.

Expand Down
Loading