Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix span kind in kafka example #1836

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[chore] Fix span kind in kafka example #1836

merged 2 commits into from
Jan 28, 2025

Conversation

geny200
Copy link
Contributor

@geny200 geny200 commented Jan 28, 2025 •
edited
Loading

Fixes #1824

Changes

Fix span kind in kafka example according to the table operation type - span kind

Merge requirement checklist

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 28, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@geny200 geny200 marked this pull request as ready for review January 28, 2025 10:07
@geny200 geny200 requested review from a team as code owners January 28, 2025 10:07
joaopgrassi
joaopgrassi approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

lmolkova
lmolkova approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Jan 28, 2025
@lmolkova lmolkova merged commit d265b4c into open-telemetry:main Jan 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@lmolkova lmolkova lmolkova approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees
No one assigned
Labels
area:messaging Skip Changelog Label to skip the changelog check
Projects
Semantic Conventions Triage
Archived in project
Spec: Messaging Semantics
Status: V1 - Stable Semantics
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency kafka example with messaging semconv
4 participants
@geny200 @trask @lmolkova @joaopgrassi