Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up BCV #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set up BCV #151

wants to merge 1 commit into from

Conversation

Goooler
Copy link

@Goooler Goooler commented Jan 22, 2025

@Goooler Goooler requested a review from a team as a code owner January 22, 2025 15:22
@TomerAberbach
Copy link
Collaborator

Thanks for the idea!

We're not gonna merge this just yet because we need to figure out how it would fit into our code generation workflow

@Goooler
Copy link
Author

Goooler commented Jan 22, 2025

  • The API check tasks has been covered by ./scripts/lint.
  • We have to run ./gradlew apiDump to reflect public APIs after each related change.

@TomerAberbach
Copy link
Collaborator

Yup, makes sense, but we'll need to figure out on our end how/when we want to run ./gradlew apiDump. The release process is automated based on changes to the Stainless code generator, we don't want someone to have to manually run ./gradlew apiDump. We'd want it to happen to automatically for major version bumps

We'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants