Update README.md to use right variable name and skip "None" at end of stream #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athyuttamre
approved these changes
Nov 28, 2023
rattrayalex
reviewed
Nov 28, 2023
Comment on lines
+97
to
+99
| for chunk in stream: | ||
| if chunk.choices[0].delta.content is not None: | ||
| print(chunk.choices[0].delta.content, end="") |
There was a problem hiding this comment.
Thoughts on this instead @logankilpatrick @athyuttamre @RobertCraigie ? (just a question of cleaner python, and I'm not a pythonista)
Suggested change
| for chunk in stream: | |
| if chunk.choices[0].delta.content is not None: | |
| print(chunk.choices[0].delta.content, end="") | |
| for chunk in stream: | |
| print(chunk.choices[0].delta.content or "", end="") |
There was a problem hiding this comment.
(either way, thanks for catching/fixing logan!)
megamanics
pushed a commit
to devops-testbed/openai-python
that referenced
this pull request
Aug 14, 2024
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.