add proposal about supporting predownload in vk #1842
Conversation
ABNER-1
force-pushed
the
proposal/support_predownload_in_vk
branch
from
5183486 to
52cd03f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
+ Coverage 47.91% 49.95% +2.04%
==========================================
Files 162 192 +30
Lines 23491 24668 +1177
==========================================
+ Hits 11256 12324 +1068
- Misses 11014 11067 +53
- Partials 1221 1277 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 对于用户在 ImageListPullJob 指定的镜像，我们根据指定的镜像创建一个临时pod，并从该pod上进行预热。 | ||
|
|
||
| 1. 增加一个字段标识是否需要在 vk 上进行预热 | ||
| 计划在已有的 ImageListPullJob CR 上增加一个字段 `spec.predownloadInVK`，用于标识是否需要在 vk 上进行预热 |
There was a problem hiding this comment.
it is not necessary to add new field, a featuregate should suffice
There was a problem hiding this comment.
I believe that in a large cluster, there may be many imageLists that require pre-download, but not necessarily all imageList need to pre-download in VK.
Generally, there are only few images will be cached, like 20 in ECI.
So it is reasonable to allow users to enable or disable it.
ABNER-1
force-pushed
the
proposal/support_predownload_in_vk
branch
from
52cd03f to
5ee31ae
Compare
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
ABNER-1
force-pushed
the
proposal/support_predownload_in_vk
branch
from
5ee31ae to
351c7a3
Compare
Ⅰ. Describe what this PR does
add proposal about supporting predownload in vk
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews