ExplicitPluginGroupId should only add groupId if artifactId is present

Fixes #4875
openrewrite · Jan 9, 2025 · d11eae9 · d11eae9
1 parent 0826417
commit d11eae9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/cleanup/ExplicitPluginGroupId.java b/rewrite-maven/src/main/java/org/openrewrite/maven/cleanup/ExplicitPluginGroupId.java
@@ -44,7 +44,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
             @Override
             public Xml visitTag(Xml.Tag tag, ExecutionContext ctx) {
                 Xml.Tag t = (Xml.Tag) super.visitTag(tag, ctx);
-                if (isPluginTag() && !t.getChild("groupId").isPresent()) {
+                if (isPluginTag() && !t.getChild("groupId").isPresent() && t.getChild("artifactId").isPresent()) {
                     Xml.Tag groupIdTag = Xml.Tag.build("<groupId>org.apache.maven.plugins</groupId>");
                     t = (Xml.Tag) new AddToTagVisitor<>(t, groupIdTag, new MavenTagInsertionComparator(t.getChildren()))
                             .visitNonNull(t, ctx, getCursor().getParentOrThrow());