-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: tls: update instructions on how to update TLS registry #29404
base: master
Are you sure you want to change the base?
NO-JIRA: tls: update instructions on how to update TLS registry #29404
Conversation
Add step-by-step instructions on how to update TLS registry
@vrutkovs: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
## Updating TLS registry | ||
|
||
In order to include unregistered TLS artifact or update certificate metadata fresh raw TLS info | ||
needs to be placed in origin's `tls/raw-data`. Raw TLS info can be obtained from test artifacts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are currently files in tls/raw-data
, does this process include updating those? i.e. should we overwrite the appropriate file with the rarwTLSInfo
or add rawTLSInfo
as a new file? Do we commit files from tls/raw-data
? Or are they temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we overwrite the appropriate file with the rarwTLSInfo or add rawTLSInfo as a new file?
Ideally you'd overwrite matching file if this adds a new certificate.
However, if you're updating metadata for existing file it needs to be consistent across other raw TLS files. This means you'd need to run all tests for all platforms and their techpreview variants.
Do we commit files from tls/raw-data? Or are they temporary?
Yes, these files need to be committed (so that make verify
would check that reports / violations are generated correctly)
0d6057a
to
1cb6e64
Compare
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 1cb6e64
|
Add step-by-step instructions on how to update TLS registry