Update openshift-kni mirroring OWNERS #60466
Conversation
Signed-off-by: Jim Ramsay <jramsay@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci-robot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] |
|
@lack: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| - nishant-parekh | ||
| - jc-rh | ||
| - browsell | ||
| - donpenney |
There was a problem hiding this comment.
These would be needed under reviewers list as well, I think?
There was a problem hiding this comment.
I thought approver implied reviewer, but I think you're right that we should all be in both places.
There was a problem hiding this comment.
Or maybe I'm right, according to this:
https://www.kubernetes.dev/docs/guide/owners/#quirks-of-the-process
There was a problem hiding this comment.
The wording there seems a little ambiguous to me. An approver giving a lgtm implies an approve, but does that imply an approver is able to give a lgtm? I know in repos where I'm both reviewer and approver, I can give an lgtm without it also adding an approve, so it's not clear to me. Could be something to experiment with
Signed-off-by: Jim Ramsay jramsay@redhat.com