-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipi-vsphere: Require min 3 control planes nodes #60488
base: master
Are you sure you want to change the base?
Conversation
/cc @jcpowermac |
/pj-rehearse auto-ack |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn |
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn |
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/assign @rvanderp3 |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@@ -111,6 +111,13 @@ VERSION=$(oc adm release info ${TESTING_RELEASE_IMAGE} --output=json | jq -r '.m | |||
|
|||
set -o errexit | |||
|
|||
# Ensure at least 3 control planes for vSphere. Single node is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will probably need to update ci-operator/step-registry/ipi/conf/vsphere/vcm/ipi-conf-vsphere-vcm-commands.sh as well. we are deprecating this step and its possible your workflow might not even be using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in d2eff0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvanderp3 Windows jobs in vSphere are using ipi-vsphere-ovn-hybrid-custom-vxlan-port that relies on ipi-conf-vsphere
.
are you saying we should move aways from ipi-conf-vsphere
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the chain not the step
https://steps.ci.openshift.org/chain/ipi-conf-vsphere
Any job that runs in CI [vsphere environment] (not devqe) will use https://steps.ci.openshift.org/reference/ipi-conf-vsphere-vcm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, makes sense.
@jrvaldes,
If the problem persists, please contact Test Platform. |
passed |
This commit adds a check to ensure that the number of control plane replicas is at least 3 for vSphere and documents the requirement.
cb0adca
to
d2eff0b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jrvaldes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[REHEARSALNOTIFIER]
A total of 1477 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn |
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
test passed, job failed at must-gather collection |
/pj-rehearse ack |
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds a check to ensure that the number of control plane replicas is at least 3 for vSphere and documents the requirement.
Follow-up to