Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipi-vsphere: Require min 3 control planes nodes #60488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Jan 9, 2025

This PR adds a check to ensure that the number of control plane replicas is at least 3 for vSphere and documents the requirement.

Follow-up to

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/cc @jcpowermac

@openshift-ci openshift-ci bot requested a review from jcpowermac January 9, 2025 15:59
@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/assign @rvanderp3

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@@ -111,6 +111,13 @@ VERSION=$(oc adm release info ${TESTING_RELEASE_IMAGE} --output=json | jq -r '.m

set -o errexit

# Ensure at least 3 control planes for vSphere. Single node is not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will probably need to update ci-operator/step-registry/ipi/conf/vsphere/vcm/ipi-conf-vsphere-vcm-commands.sh as well. we are deprecating this step and its possible your workflow might not even be using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in d2eff0b

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanderp3 Windows jobs in vSphere are using ipi-vsphere-ovn-hybrid-custom-vxlan-port that relies on ipi-conf-vsphere.

are you saying we should move aways from ipi-conf-vsphere?

Copy link
Contributor

@jcpowermac jcpowermac Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, makes sense.

@openshift-ci-robot
Copy link
Contributor

@jrvaldes, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 15a9ce34a54ee99fe340ea7f38ae63d5b605e1ec]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

This commit adds a check to ensure that the number
of control plane replicas is at least 3 for vSphere
and documents the requirement.
@jrvaldes jrvaldes force-pushed the docs-vpshere-min-reqs branch from cb0adca to d2eff0b Compare January 9, 2025 20:45
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please ask for approval from rvanderp3. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jrvaldes: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.20-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.19-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.18-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.16-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.13-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.12-e2e-vsphere-ovn-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.11-e2e-vsphere-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.10-e2e-vsphere-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.9-e2e-vsphere-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.8-e2e-vsphere-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.7-e2e-vsphere-windows openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.20-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.19-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.18-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.16-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.13-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.12-e2e-vsphere-ovn openshift/cluster-network-operator presubmit Registry content changed

A total of 1477 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jrvaldes
Copy link
Contributor Author

jrvaldes commented Jan 9, 2025

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jrvaldes
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator

test passed, job failed at must-gather collection

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60488/rehearse-60488-pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator/1877465080690380800#1:build-log.txt%3A70

@jrvaldes
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn d2eff0b link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn
ci/rehearse/openshift/cluster-api-provider-vsphere/master/regression-clusterinfra-vsphere-ipi-techpreview cb0adca link unknown /pj-rehearse pull-ci-openshift-cluster-api-provider-vsphere-master-regression-clusterinfra-vsphere-ipi-techpreview
ci/rehearse/openshift/cluster-api-provider-vsphere/release-4.17/regression-clusterinfra-vsphere-ipi-techpreview cb0adca link unknown /pj-rehearse pull-ci-openshift-cluster-api-provider-vsphere-release-4.17-regression-clusterinfra-vsphere-ipi-techpreview
ci/rehearse/openshift/windows-machine-config-operator/master/vsphere-e2e-operator d2eff0b link unknown /pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator
ci/rehearse/openshift/cluster-api-provider-vsphere/release-4.18/regression-clusterinfra-vsphere-ipi-techpreview cb0adca link unknown /pj-rehearse pull-ci-openshift-cluster-api-provider-vsphere-release-4.18-regression-clusterinfra-vsphere-ipi-techpreview
ci/rehearse/openshift/cluster-api-provider-vsphere/release-4.19/regression-clusterinfra-vsphere-ipi-techpreview cb0adca link unknown /pj-rehearse pull-ci-openshift-cluster-api-provider-vsphere-release-4.19-regression-clusterinfra-vsphere-ipi-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants