Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1542: Add data plane identities file flag to Azure run #60494

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

HOSTEDCP-1542: Add data plane identities file flag to Azure run #60494

wants to merge 1 commit into from
+12 −0

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Jan 9, 2025 •
edited
Loading

Add flags to Azure run for Workload Identity

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add data plane identities file flag to Azure run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2025
@bryan-cox
Copy link
Member Author

/hold

Needs openshift/hypershift#5363 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add flags to Azure run for Workload Identity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox marked this pull request as draft January 9, 2025 20:03
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@bryan-cox bryan-cox mentioned this pull request Jan 9, 2025
Open
4 tasks
@bryan-cox
Add flags to Azure run for Workload Identity
38ca4a7 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-master-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.20-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.19-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.18-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.17-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-master-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.18-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aks N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aks N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@Patryk-Stefanski Patryk-Stefanski Awaiting requested review from Patryk-Stefanski

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryan-cox @openshift-ci-robot