Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compliance-operator golang version to 1.23 #60496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jan 9, 2025

We recently updated the golang version in our project to 1.23:

ComplianceAsCode/compliance-operator#598

This commit updates the last reference in the CI configuration to use
1.23 as well.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jan 9, 2025

/pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-unit

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

We recently updated the golang version in our project to 1.23:

  ComplianceAsCode/compliance-operator#598

This commit updates the last reference in the CI configuration to use
1.23 as well.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-serial ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-e2e-rosa ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-go-build ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-images ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-unit ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-compliance-operator-master-verify ComplianceAsCode/compliance-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jan 9, 2025

/pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-unit

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/ComplianceAsCode/compliance-operator/master/e2e-aws-parallel 8a3f3e0 link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel
ci/rehearse/ComplianceAsCode/compliance-operator/master/images 8a3f3e0 link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-images
ci/rehearse/ComplianceAsCode/compliance-operator/master/e2e-rosa 8a3f3e0 link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-rosa
ci/rehearse/ComplianceAsCode/compliance-operator/master/e2e-aws-serial 8a3f3e0 link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants