Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sync CI Jobs with Default Transit Gateway Update by Removing power-edge-router Flag #60507

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aman4433
Copy link
Contributor

This PR removes the power-edge-router flag from CI jobs in response to the transit gateway being set as the default, as introduced in #5293 of Hypershift. With the new default transit gateway configuration, the corresponding code in the CI jobs must be updated to ensure compatibility and continuity. This change eliminates the outdated flag to align with the updated commands and configuration, preserving the consistency of the CI pipeline.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

Hi @aman4433. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aman4433
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@aman4433: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-modelmesh-serving-release-v0.11.0-alpha-fvt-odh-manifests opendatahub-io/modelmesh-serving presubmit Registry content changed
pull-ci-opendatahub-io-rest-proxy-release-v0.10.0-fvt opendatahub-io/rest-proxy presubmit Registry content changed
pull-ci-opendatahub-io-kserve-master-e2e-fast opendatahub-io/kserve presubmit Registry content changed
pull-ci-opendatahub-io-kserve-master-e2e-slow opendatahub-io/kserve presubmit Registry content changed
pull-ci-opendatahub-io-kserve-master-e2e-raw opendatahub-io/kserve presubmit Registry content changed
pull-ci-opendatahub-io-kserve-release-v0.11-e2e-fast opendatahub-io/kserve presubmit Registry content changed
pull-ci-opendatahub-io-kserve-release-v0.11-e2e-slow opendatahub-io/kserve presubmit Registry content changed
pull-ci-openshift-lvm-operator-main-e2e-aws-hypershift openshift/lvm-operator presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-unit openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23-istio-integration-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23-istio-integration-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23-istio-integration-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23.0-redhat-unit openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23.0-redhat-integ-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23.0-redhat-integ-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23.0-redhat-integ-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.23.0-redhat-integ-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-opendatahub-io-ai-edge-main-test-ai-edge opendatahub-io/ai-edge presubmit Registry content changed

A total of 58 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants