Use TS typings provided by @types/hotwired__turbo
#17654
Draft
+19
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces our own custom typings for Turbo elements and events.
This allows TypeScript to infer the correct return type for methods that accept a selector string argument, such as `document.querySelector` and `Element.closest`.
myabc
force-pushed
the
housekeeping/use-@types/hotwired__turbo-ts-typings
branch
from
f439c6c to
1673126
Compare
myabc
commented
Jan 20, 2025
Comment on lines
36
to
40
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'turbo-frame':FrameElement | ||
| } | ||
| } |
There was a problem hiding this comment.
There is an upstream PR for this: DefinitelyTyped/DefinitelyTyped#71699
8 tasks
|
Nice @myabc 👍 +1 for upstreaming our modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Although I went ahead and created this PR, it is worth mentioning that the typings provided by
@types/hotwired__turboare far from complete. We might want to invest a bit of time in making some of our own shims available upstream, e.g.frontend/src/typings/shims.d.tsMerge checklist