Code maintenance/60714 ci broken with chromedriver for chrome 132 #17708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with 132 in selenium" This reverts commit e8365e6.
From the cromedriver output: Old Headless mode has been removed from the Chrome binary. Please use the new Headless mode (https://developer.chrome.com/docs/chromium/new-headless) or the chrome-headless-shell which is a standalone implementation of the old Headless mode (https://developer.chrome.com/blog/chrome-headless-shell).
ulferts
force-pushed
the
code-maintenance/60714-ci-broken-with-chromedriver-for-chrome-132
branch
from
9dc2057 to
5f6a2de
Compare
oliverguenther
approved these changes
Jan 27, 2025
oliverguenther
deleted the
code-maintenance/60714-ci-broken-with-chromedriver-for-chrome-132
branch
|
Ah, the old headless mode was explicitly used with selenium (used And with Cuprite/Ferrum, headless was specified without explicitly asking for new or old mode (used That all makes sense now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/60714
What are you trying to accomplish?
Rely on the current chrome again by switching to the new headless mode as:
Additionally, this fixes the flickering spec for
spec/features/work_packages/table/edit_work_packages_spec.rb. The spec tried to clear an input field with the value 'Foobar'. But because the click to activate the field was happening in the middle of the string and then backspace was used, only the 'Foo' part was removed leaving 'bar'. Now the browser first goes to the end of the input before backspacing.