Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32813] Cost reports should include work package children #17720

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented Jan 24, 2025

Ticket

https://community.openproject.org/work_packages/32813

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher klaustopher force-pushed the feature/32813-cost-reports-should-include-work-package-children branch from f48cb8d to 495025c Compare January 27, 2025 13:37
@klaustopher klaustopher force-pushed the feature/32813-cost-reports-should-include-work-package-children branch from 495025c to 01f1999 Compare January 28, 2025 13:03
- Named the topmost `describe` correctly and removed one layer of indentation
- Added new tests for the new operators
- fixed specs for the `=n` operator, as it did not do anything before
@klaustopher klaustopher marked this pull request as ready for review January 28, 2025 14:01
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@oliverguenther
Copy link
Member

Just for my understanding of the visibility. This works because the filter itself restricts visibility of the work packages. The descendants itself are not restricted, and queries for.

def self.available_values(*)
WorkPackage
.where(project_id: Project.allowed_to(User.current, :view_work_packages))
.order(:id)
.pluck(:id, :subject)
.map { |id, subject| [text_for_tuple(id, subject), id] }
end

@klaustopher klaustopher merged commit 809970c into dev Jan 28, 2025
14 checks passed
@klaustopher klaustopher deleted the feature/32813-cost-reports-should-include-work-package-children branch January 28, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants