-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#32813] Cost reports should include work package children #17720
[#32813] Cost reports should include work package children #17720
Conversation
f48cb8d
to
495025c
Compare
495025c
to
01f1999
Compare
- Named the topmost `describe` correctly and removed one layer of indentation - Added new tests for the new operators - fixed specs for the `=n` operator, as it did not do anything before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Just for my understanding of the visibility. This works because the filter itself restricts visibility of the work packages. The descendants itself are not restricted, and queries for. openproject/modules/reporting/app/models/cost_query/filter/work_package_id.rb Lines 40 to 46 in 3eed62c
|
Ticket
https://community.openproject.org/work_packages/32813
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist