Add I18n locale strings for demo app (en only) #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Copies a small subset of locale strings from @opf/openproject (en only) to the demo app for improved previews when running the lookbook locally and more accurate visual regression tests/screenshots.
Screenshots
Before
After
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
@HDinger I've changed my mind a bit on this issue - I think the cost of having to maintain separate I18n strings in this repo is probably pretty small. It brings the advantage of better DX when working oninthe lookbook locally, as well as better screenshots.
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist