Enable Agama auto install on Bare Metal server #20777

rfan1 · 2024-12-11T03:09:02Z

https://progress.opensuse.org/issues/173758

Verification run:

aarch64: http://10.200.129.6/tests/81288
x86_64:
root disk: sda
root disk: nvme0n1

Now vnc console access during the installation has some problems, see https://progress.opensuse.org/issues/170434

So adding some workarounds to configure the serial console and root ssh login before rebooting the host from harddisk after installation

Currently, we are still in early phase of agama, so some new changes are expected in next few weeks

lemon-suse · 2024-12-11T05:21:45Z

In general LGTM, just need to decide to choose solution to match the installation finished page, the situation like s390x and powerVM.

tests/installation/ipxe_install.pm

alice-suse · 2024-12-11T06:23:17Z

Thanks for providing the PR.

aarch64:http://openqa.qa2.suse.asia/tests/80593
x86_64: https://openqa.suse.de/tests/16155480

Both verification jobs are red. Is this expected?

Besides, it will be good to add regression test for other supported installation ways in ipxe_install.pm, eg SLM 6.1 pxe boot, SLES pxe boot, and also aarch64 and SLM6.0 usb boot when test machines are available again(NUE2 arm machines and machines with usb(x86) are not usable after CC isolation).

alice-suse · 2024-12-11T06:34:32Z

Sorry for the accidental PR close. I closed a comment but it turned out as PR close. Reopen it.

alice-suse · 2024-12-11T06:37:50Z

In general LGTM, just need to decide to choose solution to match the installation finished page, the situation like s390x and powerVM.

@lemon-suse @jknphy What's the best solution for now and in long term?

lemon-suse · 2024-12-11T06:53:56Z

In general LGTM, just need to decide to choose solution to match the installation finished page, the situation like s390x and powerVM.

@lemon-suse @jknphy What's the best solution for now and in long term?

For now we are working on puppeteer to match the auto installation finished page, PR is on reviewing. I'm not sure it is the best solution but for us is a good solution. Besides that, we have thought to loop listen the agama log to know the installation finished, but that is not so stable and complicated, so we drop that. Joaquin will share you his idea for the long term solution. :)

alice-suse · 2024-12-11T06:58:38Z

In general LGTM, just need to decide to choose solution to match the installation finished page, the situation like s390x and powerVM.

@lemon-suse @jknphy What's the best solution for now and in long term?

For now we are working on puppeteer to match the auto installation finished page, PR is on reviewing. I'm not sure it is the best solution but for us is a good solution. Besides that, we have thought to loop listen the agama log to know the installation finished, but that is not so stable and complicated, so we drop that. Joaquin will share you his idea for the long term solution. :)

Thank you @lemon-suse ! A workable stable solution is acceptable as temporary solution, IMHO.

BTW, just to double confirm my understanding is correct, so something like https://openqa.suse.de/tests/16082855#step/agama_auto/26 is not available for ipmi machines, and what we are talking about is solution to workaround it, right? Would you please share the puppeteer PR? I am interested to have a look :)

lemon-suse · 2024-12-11T07:04:06Z

In general LGTM, just need to decide to choose solution to match the installation finished page, the situation like s390x and powerVM.

@lemon-suse @jknphy What's the best solution for now and in long term?

For now we are working on puppeteer to match the auto installation finished page, PR is on reviewing. I'm not sure it is the best solution but for us is a good solution. Besides that, we have thought to loop listen the agama log to know the installation finished, but that is not so stable and complicated, so we drop that. Joaquin will share you his idea for the long term solution. :)

Thank you @lemon-suse ! A workable stable solution is acceptable as temporary solution, IMHO.

BTW, just to double confirm my understanding is correct, so something like https://openqa.suse.de/tests/16082855#step/agama_auto/26 is not available for ipmi machines, and what we are talking about is solution to workaround it, right? Would you please share the puppeteer PR? I am interested to have a look :)

For ipmi agama test VNC not work also same as s390x and powerVM, so we are working on a solution to fix it. The puppeteer PR is jknphy/agama-integration-test-webpack#46.

tests/installation/ipxe_install.pm

jknphy · 2024-12-11T12:10:15Z

The best solution is to wait for a tool that the developers will provide to monitor the installation, but for now each squad can pick whatever it fits (no need to block each other):
https://progress.opensuse.org/issues/173758#note-16

tests/installation/ipxe_install.pm

czerw · 2024-12-12T07:08:10Z

tests/installation/ipxe_install.pm

+        }
+        if (is_ipmi) {
+            my $sol_console = is_aarch64 ? get_var('SERIALDEV', 'ttyAMA0') : get_var('SERIALDEV', 'ttyS1');
+            $cmdline_extra .= "console=$sol_console,115200 linuxrc.log=/dev/$sol_console linuxrc.core=/dev/$sol_console linuxrc.debug=4,trace ";


Please use IPXE_CONSOLE variable and don't use hardcoded speed values.

tests/installation/ipxe_install.pm

github-actions · 2024-12-12T10:58:19Z

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

lib/version_utils.pm

tests/installation/ipxe_install.pm

frankenmichl · 2024-12-17T08:30:29Z

Could you please try to do verification runs for WORKER_CLASS=64bit-i915_poo168097 and WORKER_CLASS=64bit-amd-ltp-tyrion_poo168097 on OSD?

Could you please also add verification on WORKER_CLASS=64bit-ipmi-large-mem and 64bit-ipmi-uefi? Thanks!

WORKER_CLASS=64bit-ipmi-large-mem-> passed WORKER_CLASS=64bit-ipmi-uefi-> failed due to https://progress.opensuse.org/issues/174448

WORKER_CLASS=64bit-i915_poo168097 and WORKER_CLASS=64bit-amd-ltp-tyrion_poo168097: failed, I would say due to CC, host is in NUE, but ipxe server is in PRG

You specified the wrong server. The machines have the server in their definition on OSD, which is IPXE_HTTPSERVER=http://baremetal-support.qa.suse.de:8080 - that was the original one. For the machines located in nue2 we have that defined along the machine definition.
We can go ahead without these verification runs I think.

variables.md

alice-suse · 2024-12-18T01:53:01Z

Could you please try to do verification runs for WORKER_CLASS=64bit-i915_poo168097 and WORKER_CLASS=64bit-amd-ltp-tyrion_poo168097 on OSD?

Could you please also add verification on WORKER_CLASS=64bit-ipmi-large-mem and 64bit-ipmi-uefi? Thanks!

WORKER_CLASS=64bit-ipmi-large-mem-> passed WORKER_CLASS=64bit-ipmi-uefi-> failed due to https://progress.opensuse.org/issues/174448

Thanks! For 64bit-ipmi-uefi, you can specify with worker_class='bare-metal1', this one works now.

https://progress.opensuse.org/issues/173758

rfan1 · 2024-12-18T04:26:16Z

Could you please try to do verification runs for WORKER_CLASS=64bit-i915_poo168097 and WORKER_CLASS=64bit-amd-ltp-tyrion_poo168097 on OSD?

Could you please also add verification on WORKER_CLASS=64bit-ipmi-large-mem and 64bit-ipmi-uefi? Thanks!

WORKER_CLASS=64bit-ipmi-large-mem-> passed WORKER_CLASS=64bit-ipmi-uefi-> failed due to https://progress.opensuse.org/issues/174448

Thanks! For 64bit-ipmi-uefi, you can specify with worker_class='bare-metal1', this one works now.

passed :) http://openqa.suse.de/tests/16233654#

alice-suse

Thanks for the effort!

rfan1 · 2024-12-18T08:37:46Z

Thanks all for your comments and reviews! I plan to merge this PR now. and make it a milestone. as I can't solve all problem from this single commit, some new agama features will come soon [scc support/post scripts etc], there are still some pending issues/bugs like:
https://bugzilla.suse.com/show_bug.cgi?id=1234678 and https://bugzilla.suse.com/show_bug.cgi?id=1234264.

Dawei-Pang · 2024-12-18T08:37:49Z

So far agama installer cannot reboot automatically although agama.auto added in kernel boot command line, could this codes check and confirm if the installation complete? Thanks!

rfan1 · 2024-12-18T08:39:08Z

So far agama installer cannot reboot automatically although agama.auto added in kernel boot command line, could this codes check and confirm if the installation complete? Thanks!

AGAMA_AUTO | string | | The auto-installation is started by passing agama.auto=<url> on the kernel's command line,
So IMO it doesn't control auto reboot :)

Dawei-Pang · 2024-12-18T08:48:03Z

So far agama installer cannot reboot automatically although agama.auto added in kernel boot command line, could this codes check and confirm if the installation complete? Thanks!

I find the code verify_agama_auto_install_done_cmdline() implement this feature to confirm installation complete.

rfan1 force-pushed the ipxe_sle16 branch 2 times, most recently from 0f6e486 to ed54fae Compare December 11, 2024 04:00

rfan1 requested review from Julie-CAO and alice-suse December 11, 2024 04:39

alice-suse reviewed Dec 11, 2024

View reviewed changes

tests/installation/ipxe_install.pm Outdated Show resolved Hide resolved

alice-suse reviewed Dec 11, 2024

View reviewed changes

tests/installation/ipxe_install.pm Outdated Show resolved Hide resolved

alice-suse closed this Dec 11, 2024

alice-suse reopened this Dec 11, 2024

jknphy reviewed Dec 11, 2024

View reviewed changes

tests/installation/ipxe_install.pm Outdated Show resolved Hide resolved

rfan1 force-pushed the ipxe_sle16 branch 7 times, most recently from a36014e to a224d88 Compare December 12, 2024 02:40

czerw requested changes Dec 12, 2024

View reviewed changes

rfan1 force-pushed the ipxe_sle16 branch from a224d88 to 3747301 Compare December 12, 2024 10:57

czerw requested changes Dec 12, 2024

View reviewed changes

lib/version_utils.pm Outdated Show resolved Hide resolved

rfan1 force-pushed the ipxe_sle16 branch 2 times, most recently from 1bb3699 to 8e94d48 Compare December 12, 2024 12:03

rfan1 force-pushed the ipxe_sle16 branch from b19e80d to 2278034 Compare December 17, 2024 05:54

jknphy approved these changes Dec 17, 2024

View reviewed changes

waynechen55 reviewed Dec 17, 2024

View reviewed changes

tests/installation/ipxe_install.pm Show resolved Hide resolved

waynechen55 reviewed Dec 17, 2024

View reviewed changes

tests/installation/ipxe_install.pm Outdated Show resolved Hide resolved

waynechen55 reviewed Dec 17, 2024

View reviewed changes

tests/installation/ipxe_install.pm Show resolved Hide resolved

rfan1 changed the title ~~[wip]Agama BM~~ Enalbe Agama auto install on Bare Metal server Dec 17, 2024

rfan1 force-pushed the ipxe_sle16 branch 2 times, most recently from d7e2caf to 54aae95 Compare December 17, 2024 08:54

rfan1 changed the title ~~Enalbe Agama auto install on Bare Metal server~~ Enable Agama auto install on Bare Metal server Dec 17, 2024

lemon-suse approved these changes Dec 17, 2024

View reviewed changes

RoyCai7 reviewed Dec 17, 2024

View reviewed changes

variables.md Outdated Show resolved Hide resolved

RoyCai7 reviewed Dec 17, 2024

View reviewed changes

variables.md Outdated Show resolved Hide resolved

rfan1 force-pushed the ipxe_sle16 branch from 54aae95 to 96d6f17 Compare December 18, 2024 01:29

Enable Agama auto install on Bare Metal server

51ba290

https://progress.opensuse.org/issues/173758

rfan1 force-pushed the ipxe_sle16 branch 4 times, most recently from 224ddd3 to 51ba290 Compare December 18, 2024 04:59

alice-suse approved these changes Dec 18, 2024

View reviewed changes

rfan1 merged commit 6ed938f into os-autoinst:master Dec 18, 2024
10 checks passed

This was referenced Dec 18, 2024

Fix serial console settings for agama install #20835

Merged

Add Agama installation support for powerVM #20850

Merged

Add agama installation for s390x kvm #20869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Agama auto install on Bare Metal server #20777

Enable Agama auto install on Bare Metal server #20777

rfan1 commented Dec 11, 2024 •

edited

Loading

lemon-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024 •

edited

Loading

alice-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024

lemon-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024

lemon-suse commented Dec 11, 2024

jknphy commented Dec 11, 2024

czerw Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024

frankenmichl commented Dec 17, 2024

alice-suse commented Dec 18, 2024

rfan1 commented Dec 18, 2024

alice-suse left a comment

rfan1 commented Dec 18, 2024

Dawei-Pang commented Dec 18, 2024

rfan1 commented Dec 18, 2024 •

edited

Loading

Dawei-Pang commented Dec 18, 2024

Enable Agama auto install on Bare Metal server #20777

Enable Agama auto install on Bare Metal server #20777

Conversation

rfan1 commented Dec 11, 2024 • edited Loading

lemon-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024 • edited Loading

alice-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024

lemon-suse commented Dec 11, 2024

alice-suse commented Dec 11, 2024

lemon-suse commented Dec 11, 2024

jknphy commented Dec 11, 2024

czerw Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2024

frankenmichl commented Dec 17, 2024

alice-suse commented Dec 18, 2024

rfan1 commented Dec 18, 2024

alice-suse left a comment

Choose a reason for hiding this comment

rfan1 commented Dec 18, 2024

Dawei-Pang commented Dec 18, 2024

rfan1 commented Dec 18, 2024 • edited Loading

Dawei-Pang commented Dec 18, 2024

rfan1 commented Dec 11, 2024 •

edited

Loading

alice-suse commented Dec 11, 2024 •

edited

Loading

czerw Dec 12, 2024 •

edited

Loading

rfan1 commented Dec 18, 2024 •

edited

Loading