Allow (rate limited) leave requests events to be repeated #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a leave request gets missed (because of an exceptional circumstance on the Oxen chain) then the Oxen chain never gets the confirmed leave request, and so the node cannot complete a normal, graceful exit because the Oxen SN network will never sign a leave request. While there *is* a contract fallback for this, it triggers after 30 days, meaning the SN's obligations get extended by an extra 15 days, which may be undeseriable (for example, if someone has scheduled cancellation of a hosting plan). This commit removes the revert for a repeated request so that if such a situation does occur, the operator or a contributor can submit another leave request call to attempt to propagate the event through to oxend again. Such duplicates can be helpful (as described above), but are otherwise harmless: oxend simply ignores a leave request for an already-unlocking node. Such a subsequent request does *not* affect the leave request timestamp, but merely reissues a leave request event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further iterates on #95 this adds a rate limit how often the leave request can be initiated because it's spammable. In the optimistic case, the chain will take around ~15mins to confirm so the it should rate-limit the request to at least once per 15 minutes. In this commit I've chosen 1 hour.