Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding indent_blocks to the lexer #1456

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GergelyKalmar
Copy link

@GergelyKalmar GergelyKalmar commented May 30, 2021

We're adding a new indent_blocks environment parameter which automatically indents/dedents block contents. This allows us to add indentation to code block contents (which helps readability) while making sure that the output is also indented nicely.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@GergelyKalmar
Copy link
Author

@davidism I've given a stab at #178, although I got a little stuck at some more complex nested / inline templates. It would be great if you could let me know if you agree with the direction in general (in which case I'd be happy to continue working on this)! Also, if you have any ideas how to proceed with fixing the failing nested test, let me know.

Thank you!

@GergelyKalmar
Copy link
Author

@davidism Any chance to get some feedback on this PR? I'd still be up for continuing the work on it if that's desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserving whitespace prefix in multiline strings
2 participants