refactor: Make TransactionValidationOutcome generic over error type

[PanGan21]

Closes: #14037

Makes TransactionValidationOutcome generic over error type.

[emhane]

yes, we want to generalise the impl body too

impl<T: PoolTransaction, E> TransactionValidationOutcome<T, E> { .. }

[mattsse]

hmm,

this error already supports arbitrary errors via

reth/crates/transaction-pool/src/error.rs

Lines 223 to 225 in d3cec5a

	/// Any other error that occurred while inserting/validating that is transaction specific
	#[error(transparent)]
	Other(Box<dyn PoolTransactionError>),

skeptical that it's worth integrating an error type

which I think would need to be added to

reth/crates/transaction-pool/src/pool/mod.rs

Line 132 in d3cec5a

pub struct PoolInner<V, T, S>

[emhane]

rollups want to match on their error variants @mattsse . eventually all components that are customisable at sdk level should have an error associated type for good devx.

[mattsse]

rollups want to match on their error variants

what's a use case for this?

[emhane]

rollups want to match on their error variants

what's a use case for this?

do smthg based on the error variant

[mattsse]

can we add a helper that typechecking the dyn PollError instead, don't think a dedicated type for this is super useful

[emhane]

can we add a helper that typechecking the dyn PollError instead, don't think a dedicated type for this is super useful

sure rollups can work with down casting. though semantically it's nicer for the rollups to wrap l1 errors in a variant, so they can extend it. another place I'm having the same problem rn is PayloadError from alloy. in upcoming op fork there is a need for adding other error variants for failing payload validation. instead of moving this problem to alloy to add an Other variant, it would be nicer if the trait PayloadValidator had an associated type for error.

[PanGan21]

yes, we want to generalise the impl body too

impl<T: PoolTransaction, E> TransactionValidationOutcome<T, E> { .. }

I added this for now.
In case the approach needs to change and add the type checking helper function please let me know :)

[mattsse]

@PanGan21

can we instead make this

reth/crates/transaction-pool/src/error.rs

Line 14 in 440e669

pub trait PoolTransactionError: core::error::Error + Send + Sync {

`: Any``

and add

    #[inline]
    fn as_any(&self) -> &dyn std::any::Any;

to the trait?

[emhane]

lgtm

[mattsse]

actually @PanGan21 we probably don't need the additional Any fn if we require that this trait is 'static

and add these helper functions

#14180

to

reth/crates/transaction-pool/src/error.rs

Line 189 in 04c1d71

pub enum InvalidPoolTransactionError {