adds a `signature::Signer` interface #537

baloo · 2024-08-03T23:16:03Z

This brings an implementation of a signature::Signer for keys stored on the TPM.

This is intend to make for easier re-use of this crate and to allow to:

Create certificates https://docs.rs/x509-cert/latest/x509_cert/builder/struct.CertificateBuilder.html
Create CSRs https://docs.rs/x509-cert/latest/x509_cert/builder/struct.RequestBuilder.html
Sign documents with S/MIME https://docs.rs/cms/latest/cms/builder/index.html

Here is an implementation of an SSH agent making use of that infrastructure: wiktor-k/ssh-agent-lib#87

Superhepper

Sorry for reviewing a WIP though I found it a little bit interesting so I couldn't help my self. Feel free to disregard anything I have commented on.

tss-esapi/src/abstraction/public.rs

tss-esapi/src/abstraction/transient/signer.rs

tss-esapi/src/interface_types/algorithm.rs

tss-esapi/src/structures/signatures.rs

tss-esapi/tests/integration_tests/abstraction_tests/public_tests.rs

baloo · 2024-08-04T20:38:23Z

Sorry for reviewing a WIP though I found it a little bit interesting so I couldn't help my self. Feel free to disregard anything I have commented on.

Oh, no, thanks for reviewing it!
I sent it a bit early as this is work I've been putting off for almost a year now. I'm doing it mostly to get a sense whether this is a direction the project could go or not.

ionut-arm

Thank you for bringing the patch! The overall design looks good to me.

ionut-arm · 2024-08-05T22:42:18Z

tss-esapi/src/abstraction/signatures.rs

+// Note: this does not implement `TryFrom<RsaSignature>` because `RsaSignature` does not carry the
+// information whether the signatures was generated using PKCS#1v1.5 or PSS.


The fields of RsaSignature are private, so we can extend it to capture this detail as well. It's a deviation from the TPM spec, but I don't necessarily see a problem with it. Thoughts?

cc @Superhepper

No it is not really a problem as long as it does not causes any ambiguities in the conversions between TPMS_SIGNATURE_RSA and RsaSignature.

I think it's fine like that, the comment was more for a future self why we would not have such a TryFrom

ionut-arm · 2024-08-05T22:46:56Z

tss-esapi/src/abstraction/transient/signer.rs

+use signature::{DigestSigner, Error as SigError, KeypairRef};
+
+#[derive(Debug)]
+pub struct Ecdsa<'ctx, C>


(I know this is a draft: ) Would be good to have some docs on these structs to make it clear what they're meant for.

I tried to add some, and add a code sample in the doc as well.

ionut-arm · 2024-08-05T22:58:11Z

tss-esapi/src/abstraction/transient/signer.rs

+    /// Key parameters for this curve
+    pub fn key_params<D>() -> KeyParams


I'm a bit mystified by the purpose of this function. Also by the use of "this curve" in the doc for it, given that Ecdsa is presumably not the description of a curve (?)

C describes the curve (could be NistP256, NistP384, NistP521, ...) those are all supported here. When using the signer (through the Ecdsa struct) you would specify which curve you're using.

This would pick the correct parameters to specify to the TPM when signing, the size of the object that comes back from signature, how to verify them, ...

This function just creates the TPM parameters related to this curve and the selected digest.

Sure, I think I was mostly confused by the existence of two nearly-identical methods before, and that the struct they're tacked to doesn't represent (just) a specific curve.

The key_params_default just use the "default" hashing mechanism for a given curve (P256 would use sha256, P384 would use sha384, etc).

The hashing methods needs to line up otherwise the curve has a higher "security score" than the hashing mechanism it uses and it's a waste of space.

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs

tss-esapi/src/abstraction/hashing.rs

baloo · 2025-01-24T22:59:13Z

The two remaining failing tests should be fixed by #562 I'll rebase once that merges.

Superhepper

I think it looks fine though my experience with these things are quite limited so I mainly focused on the code structure and concepts.

One thing that will always be discussed is conversions from reference types. I think it is ok here because I do not see any clone or to_owned any where.

wiktor-k

I think it looks good, a couple of question-nits...

tss-esapi/src/abstraction/public.rs

tss-esapi/src/abstraction/transient/signer.rs

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 85783cc to 6525f15 Compare August 3, 2024 23:17

baloo mentioned this pull request Aug 3, 2024

WIP: examples: adds an agent storing keys on TPMs wiktor-k/ssh-agent-lib#87

Draft

1 task

baloo marked this pull request as draft August 3, 2024 23:20

baloo force-pushed the baloo/rust-crypto/signer-interface branch 2 times, most recently from 336466d to 8145f8e Compare August 4, 2024 03:35

Superhepper reviewed Aug 4, 2024

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch 6 times, most recently from df740fd to eaf82d5 Compare August 4, 2024 16:28

ionut-arm reviewed Aug 5, 2024

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch 3 times, most recently from fe52b1c to fa8ff3a Compare August 6, 2024 23:16

baloo mentioned this pull request Aug 6, 2024

signature_derive: adds support for lifetimes RustCrypto/traits#1641

Closed

baloo force-pushed the baloo/rust-crypto/signer-interface branch 4 times, most recently from 7bcbb0c to b79e193 Compare August 7, 2024 03:33

baloo commented Aug 7, 2024

View reviewed changes

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs Show resolved Hide resolved

baloo commented Aug 7, 2024

View reviewed changes

tss-esapi/tests/integration_tests/abstraction_tests/transient_key_context_tests.rs Show resolved Hide resolved

baloo force-pushed the baloo/rust-crypto/signer-interface branch from b79e193 to 9f760ad Compare August 7, 2024 05:29

wiktor-k reviewed Aug 7, 2024

View reviewed changes

tss-esapi/src/abstraction/hashing.rs Outdated Show resolved Hide resolved

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 9f760ad to edf67ed Compare August 7, 2024 16:37

rucoder mentioned this pull request Jan 23, 2025

v8.0.0 stabilization work #495

Open

5 tasks

baloo force-pushed the baloo/rust-crypto/signer-interface branch from edf67ed to 73e0b9c Compare January 24, 2025 20:05

baloo marked this pull request as ready for review January 24, 2025 20:05

baloo force-pushed the baloo/rust-crypto/signer-interface branch 3 times, most recently from 0c34e21 to 1ce212a Compare January 24, 2025 20:21

baloo changed the title ~~WIP: adds a signature::Signer interface~~ adds a signature::Signer interface Jan 24, 2025

baloo force-pushed the baloo/rust-crypto/signer-interface branch 4 times, most recently from 4c1ee47 to 9ef5f92 Compare January 24, 2025 22:49

Superhepper previously approved these changes Jan 26, 2025

View reviewed changes

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 9ef5f92 to 91fe771 Compare January 26, 2025 16:39

baloo dismissed Superhepper’s stale review via 55831ae January 26, 2025 23:12

baloo force-pushed the baloo/rust-crypto/signer-interface branch from 91fe771 to 55831ae Compare January 26, 2025 23:12

wiktor-k previously approved these changes Jan 27, 2025

View reviewed changes

baloo dismissed wiktor-k’s stale review via 01d0df7 January 27, 2025 18:14

baloo force-pushed the baloo/rust-crypto/signer-interface branch 2 times, most recently from 01d0df7 to af146ef Compare January 27, 2025 20:50

baloo mentioned this pull request Jan 27, 2025

Bump picky- crates #560

Open

baloo force-pushed the baloo/rust-crypto/signer-interface branch from af146ef to e21adf0 Compare January 28, 2025 08:04

baloo mentioned this pull request Jan 29, 2025

WIP: support for pure-rust make credentials #563

Open

baloo added 7 commits January 30, 2025 09:10

Bring rustcrypto ecosystem

8bd488a

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

tss-esapi: move public keys to rustcrypto ecosystem

23e553b

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

bridge digest crate with tpm digests

e949530

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

adds a AssociatedHashingAlgorithm to bridge to rustcrypto

d80046e

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

Convert signature to ecdsa::Signature

189699f

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

Convert signature to rsa signatures

e784c9c

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

adds a signature::Signer implementation for ecc keys

ad664c0

Signed-off-by: Arthur Gautier <arthur.gautier@arista.com>

baloo force-pushed the baloo/rust-crypto/signer-interface branch from e21adf0 to ad664c0 Compare January 30, 2025 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds a `signature::Signer` interface #537

adds a `signature::Signer` interface #537

baloo commented Aug 3, 2024

Superhepper left a comment

baloo commented Aug 4, 2024

ionut-arm left a comment

ionut-arm Aug 5, 2024

Superhepper Aug 6, 2024

baloo Aug 6, 2024

ionut-arm Aug 5, 2024

baloo Aug 6, 2024

ionut-arm Aug 5, 2024

baloo Aug 6, 2024

ionut-arm Aug 7, 2024

baloo Jan 25, 2025

baloo commented Jan 24, 2025

Superhepper left a comment

wiktor-k left a comment

		// Note: this does not implement `TryFrom<RsaSignature>` because `RsaSignature` does not carry the
		// information whether the signatures was generated using PKCS#1v1.5 or PSS.

		/// Key parameters for this curve
		pub fn key_params<D>() -> KeyParams

adds a signature::Signer interface #537

Are you sure you want to change the base?

adds a signature::Signer interface #537

Conversation

baloo commented Aug 3, 2024

Superhepper left a comment

Choose a reason for hiding this comment

baloo commented Aug 4, 2024

ionut-arm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baloo commented Jan 24, 2025

Superhepper left a comment

Choose a reason for hiding this comment

wiktor-k left a comment

Choose a reason for hiding this comment

adds a `signature::Signer` interface #537

adds a `signature::Signer` interface #537