Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX/IBM i support #133

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

AIX/IBM i support #133

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e0c2189
Add AIX/i to build
NattyNarwhal Jan 10, 2023
265ac37
WIP: import IBM's *at shims
NattyNarwhal Feb 7, 2023
32f202c
Fix link issue on AIX (need threaded C++ lib)
NattyNarwhal Feb 7, 2023
b1fe594
fix -fpermissive
NattyNarwhal Feb 7, 2023
5d517fe
We don't need d_type if we did a stat
NattyNarwhal Feb 7, 2023
45d9926
silly me forgot to fix the other -fpermissive
NattyNarwhal Feb 7, 2023
dc4b897
try to move shims to separate file
NattyNarwhal Mar 16, 2023
a58970d
Fix typo
NattyNarwhal Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,26 @@
"BRUTE_FORCE"
]
}],
# Depending on version of Python, IBM i can identify as AIX or OS400
['OS=="aix" or OS=="os400"', {
"sources": [
"src/watchman/BSER.cc",
"src/watchman/WatchmanBackend.cc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow response on this PR.

One problem is that I don't think watchman is supported on AIX or OS400. There is also no inotify support as far as I can tell (I don't have access to a system to test this). Without either of those, this module isn't very useful (can't actually watch files). Do you know if these OSes have another file watching mechanism?

I'm also somewhat concerned about adding these as I have no way of testing or providing precompiled builds for these platforms. Do you have access to such a system to test with?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late response.

Watchman isn't supported, but I didn't disable it, because Watchman is an external tool - I was thinking that it might support it or an alternative with a compatible interface might. It might be a good idea to disable it though.

It's using the "legacy" backend which is brute force; AFAIK there is no watching API, but I might be wrong. I can ask my contacts at IBM.

I understand the concerns about not being able to test things. I do have access to a system for testing. FWIW not having a binary build is OK; the user I'm doing this for is already used to having the dev toolchain to build native parts already.

(FWIW, the motivation to upstream this was things depending on watcher being extremely common in some ecosystems. Finding and patching every dependency to pull a patched copy was too onerous.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a ping out here - would like to know if the above is still blocking.

"src/shared/BruteForceBackend.cc",
"src/unix/legacy.cc"
],
"defines": [
"WATCHMAN",
"BRUTE_FORCE"
],
# Required for threaded parts of stdc++
'ldflags': [
'-pthread',
],
'cflags': [
'-pthread',
],
}],
['OS=="win"', {
"sources": [
"src/watchman/BSER.cc",
Expand Down
Loading