fix: Parse.setServer doesn't properly validate URL (#1844)

parse-community · Jan 31, 2025 · d7b1c8e · d7b1c8e
1 parent e947529
commit d7b1c8e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme b/Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme
@@ -96,9 +96,6 @@
                <Test
                   Identifier = "ParseClientConfigurationTests/testExtensionDataSharing">
                </Test>
-               <Test
-                  Identifier = "ParseClientConfigurationTests/testServerValidation">
-               </Test>
             </SkippedTests>
          </TestableReference>
       </Testables>

diff --git a/Parse/Parse/Source/ParseClientConfiguration.m b/Parse/Parse/Source/ParseClientConfiguration.m
@@ -69,8 +69,9 @@ - (void)setClientKey:(NSString *)clientKey {
 }
 
 - (void)setServer:(NSString *)server {
+    NSURL *url = [NSURL URLWithString:server];
     PFParameterAssert(server.length, @"Server should not be `nil`.");
-    PFParameterAssert([NSURL URLWithString:server], @"Server should be a valid URL.");
+    PFParameterAssert(url && url.scheme && url.host, @"Server should be a valid URL.");
     _server = [server copy];
 }