-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isDataAvailableForKey should be public to easier to check data available #1595
Conversation
… for key, you don't need to fetch all data to get a certain data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general but why did you include the change in ParseUI into this PR? Is this on purpose?
It's on purpose, it's just a minor fix to silent the "variable not used" warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well then it looks good to me
This issue has been automatically marked as stale because it has not had recent activity. If you believe it should stay open, please let us know! As always, we encourage contributions, check out the Contributing Guide |
@@ -213,7 +213,7 @@ - (void)layoutSubviews { | |||
frame.origin.y = currentY + loginButtonTopInset; | |||
_signUpButton.frame = frame; | |||
|
|||
currentY = CGRectGetMaxY(frame); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being kept commented though?
Closing a superseded by #1756 |
… so you don't need to fetch all data to get a certain data.
Sometimes the data of a user is very long but we just need to get the "username" which is already fetched.
This PR also avoid crashing when we try to get data from key which is not fetched. It should returns nil.
So we could check or get data by either ways:
or