Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Facebook SDK dependency to latest version 17.x and remove ParseFacebookUtilsTvOS #1776

Closed
wants to merge 2 commits into from

Conversation

chriscborg
Copy link

New Pull Request Checklist

Issue Description

This aims to resolve a compatibility issue with Xcode 15.3 and the Facebook SDK, bumping Facebook SDK version to 17.x. This Pull Request forks from an existing PR #1774. Credits to matteolongeri-ovolab.

Closes: #1775
Closes: #1773
Closes: #1764

Approach

Updated Swift package to update the Facebook SDK to latest version which resolves this compatibility issue.

To Do before merging

  • Update documentation specifying that ParseFacebookUtilsTvOS has been removed.

Credits

matteolongeri-ovolab for Pull Request #1774

matteolongeri-ovolab and others added 2 commits March 18, 2024 11:36
…UtilsTvOS since with Facebook SDK version 16.x support for FacebookTV has been dropped
Copy link

parse-github-assistant bot commented Apr 5, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@chriscborg chriscborg changed the title Update Facebook SDK dependency to latest version 17.x and remove ParseFacebookUtilsTvOS fix: Update Facebook SDK dependency to latest version 17.x and remove ParseFacebookUtilsTvOS Apr 5, 2024
@chriscborg
Copy link
Author

After performing this upgrade, when logging in using PFFacebookUtils.logInInBackground, I'm getting an error 101 from Parse "Facebook auth is invalid for this user". Not sure how to resolve this one though. Any ideas please?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires a rebase. Also, how about removing the FacebookUtils altogether, instead of constantly updating them?

@mtrezza
Copy link
Member

mtrezza commented Apr 8, 2024

Closing via #1779

@mtrezza mtrezza closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants