-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove support for Xcode 14 #1835
Conversation
Thanks for opening this pull request!
|
@mtrezza Looks like there are 3 failing / flaky tests, the starter projects build correctly on Xcode 15/16
|
Great, do you have any guesses why they are failing? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1835 +/- ##
===========================================
+ Coverage 64.24% 82.65% +18.40%
===========================================
Files 201 282 +81
Lines 23233 30723 +7490
===========================================
+ Hits 14926 25393 +10467
+ Misses 8307 5330 -2977 ☔ View full report in Codecov by Sentry. |
@mtrezza I disabled the tests for now but I kinda figured out what is wrong. There are currently 3 trackers for the app badges.
Will fix in a separate PR. |
Great, is that a SDK bug you discovered or just a testing issue? |
I think it's a testing issue but could be a bug. I don't think it's safe to have an observer on |
@mtrezza This is ready for review |
I went back to individual jobs for LiveQuery, as it turned out that it's hard to debug in a combined test, and takes longer. Turns out that finding the right simulator settings to get the job working can take some time; that doesn't seem to be a code issue, but just how the simulator destination is set up. Instead of specifying the simulator by its ID we are selecting OS version and device model, which can be ambiguous, especially in watchOS <> iOS peering hence the test can easily fail because of the system OS / Xcode / simulator OS version compatibility. |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
The CI is currently broken due to simulators not being support across 3 versions of Xcode.
Closes: #1836
Approach
TODOs before merging