This repository has been archived by the owner on Apr 7, 2019. It is now read-only.
Fixes generation errors #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerasai
commented
Mar 26, 2019
| @@ -1,4 +1,3 @@ | |||
| {% import "@macros/forms.twig" as forms %} | |||
There was a problem hiding this comment.
Explicit import not necessary per https://github.com/pattern-lab/patternengine-php-twig#macros.
forms.twig renamed to forms.macro.twig per the macro extension defined in the config.yml.
| @@ -1,4 +1,4 @@ | |||
| {% extends "@templates/page-2col.twig" %} | |||
| {% extends "@templates/00-layouts/01-page-2col.twig" %} | |||
There was a problem hiding this comment.
This reference is just incorrect.
Other includes within the template appear to be incorrect as well, but they do not prevent the generation from completing. May want to consider updating all of these, possibly using the pattern include partial syntax.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to run
php core/console --generatefatal PHP errors are generated due to a couple of issues in the starterkit.These changes address the following issues and pull requests: