Add pre-commit #76
Merged
Add pre-commit #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobMiksch
force-pushed
the
pre-commit
branch
from
ee71133 to
10dfb6e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use pre-commit in some other projects and find it useful to ensure basic file syntax is ensured. It can also be run locally on every commit while developing, but this is not required. However, every commit pushed to GitHub will be checked using pre-commit.
In future more linters like
black,flake8, markdown-linting or other Python stuff could be added.Just let me know if you find this useful or not. Then we can merge, or I close the PR again. Both is fine