core: advance reader's position if pattern cannot be found, fixes out of memory from #301 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeljanov
reviewed
Jan 18, 2025
| return Ok(&self.buf[start..end]); | ||
| } | ||
|
|
||
| let mut j = start; | ||
| let mut i = start + pattern.len(); | ||
| let mut i = start; |
There was a problem hiding this comment.
Why were these renamed? Usually the outer loop variable is i, and j is the inner loop. It adds noise the commit. Or am I missing something subtle?
There was a problem hiding this comment.
sorry it was hard to read for me that i is greater than j.
I agree with your statement about outer and inner loop, but there is a single loop here and buf[j..i] looked too wierd for me.
np I can remove this, just confirm you want to remove noise.
There was a problem hiding this comment.
Okay, if it's too weird to you then it's probably too weird to others as well. I merged it as is.
It was looking strange to me because there is a single loop, but j was being used in the loop condition instead of i.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses out-of-memory errors mentioned in the following comment: #301 (comment).
Issue description:
For a big buffer where the pattern was not found at the end, the reader advanced its position to the end of the buffer.
For a buffer smaller than the pattern length, the reader did not advance its position and entered into infinite loop while reading tags.
This commit ensures that the reader's position is always advanced, resolving the issue.