adpcm: report unsupported error for more than 2 channels #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeljanov
requested changes
Jan 18, 2025
symphonia-codec-adpcm/src/lib.rs
Outdated
| @@ -140,7 +140,7 @@ impl AdpcmDecoder { | |||
| decode_stereo(&mut stream, buffers, frames_per_block)?; | |||
| } | |||
| } | |||
| _ => unreachable!(), | |||
| _ => return unsupported_error("adpcm: up to two channels are supported"), | |||
There was a problem hiding this comment.
This isn't the correct place to return an unsupported error, especially since the channel count is constant after instantiation.
Please move this validation check to try_new before we create the audio buffer with > 2 channels (line 91 seems good).
|
fixed. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes panic