Relatively small Unicode wins #290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might decide to take some pieces of this, all of it, or continue on to add (perhaps-optional?) support for non-BMP character classes. |
|
The |
reverofevil
reviewed
Jun 13, 2022
| @@ -33,12 +33,15 @@ line | |||
| / buzz | |||
|
|
|||
| fizzbuzz = f:fizz _ b:buzz { return f + b } | |||
| fizz = @"fizz"i !{ return currentNumber % 3 } | |||
| buzz = @"buzz"i !{ return currentNumber % 5 } | |||
| \u0066izz 'fizz' = @"fizz"i !{ return currentNumber % 3 } | |||
There was a problem hiding this comment.
(oh god not another language of this please)
There was a problem hiding this comment.
Honestly I'd rather ban everything outside of [a-z_]i[a-z0-9_]i.
hildjj
force-pushed
the
astral
branch
3 times, most recently
from
cc5094e to
fa92718
Compare
hildjj
force-pushed
the
astral
branch
2 times, most recently
from
d9787e0 to
c21d7f6
Compare
…capeSequence is used.
|
Breaks on this grammar: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype for dealing with Unicode codepoints above U+FFFF. In JavaScript, you can spell these
\u{1f41d}(U+1f41d: HONEYBEE 🐝).Added:
"strings"can use escapes like\u{1f41d}. For non-BMP characters, these escapes generate two UTF-16 bytes..now matches full non-BMP characters