Skip to content

Commit

Permalink
Relax version restrictions of protobuf dependency (foxglove#1017)
Browse files Browse the repository at this point in the history
### Public-Facing Changes

Relax version restrictions of protobuf dependency

### Description
Changed the protobuf version restrictions to exclude the 4.22-4.24 which
could lead to segmentation faults when reading a mcap file. We
previously tightened it in foxglove#919
  • Loading branch information
achim-k authored and pezy committed Jan 11, 2024
1 parent af4d3b7 commit 069a1bf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions python/mcap-protobuf-support/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ classifiers =
Operating System :: OS Independent

[options]
install_requires =
install_requires =
mcap>=0.0.14
protobuf>=3.8,<=4.21.11
# Protobuf versions 4.22-4.24 are excluded as they contain a bug that can cause a segmentation
# fault when reading a mcap file: https://github.com/protocolbuffers/protobuf/issues/12047
protobuf>=3.8,!=4.22.*,!=4.23.*,!=4.24.*
install_package_data = True
packages = find:
python_requires = >=3.7
Expand Down

0 comments on commit 069a1bf

Please sign in to comment.