-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub queries for is_in
and not_in
#786
base: master
Are you sure you want to change the base?
Conversation
@dantownsend Sorry to bother, but I wonder why you didn't merge this (I know the tests are missing) because I think it's really useful and convenient, and the performance is approx. 50% better on a GET request because we don't have to make two separate queries but just one? |
@sinisaos Yeah, it's a good point. Like you say, it just needs test and docs, and they shouldn't take too long to add. I'll try and finish it up and get it merged. |
@dantownsend Great. Thanks. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 91.62% 91.56% -0.07%
==========================================
Files 109 109
Lines 7885 7897 +12
==========================================
+ Hits 7225 7231 +6
- Misses 660 666 +6
|
Can we perhaps make it so that piccolo handles the case where we put in an empty list? It can be useful when the list is dynamically generated, and there are different conditions in the where clause. Maybe this would work? |
@powellnorma I usually have to add a check before any query with an |
Resolves #785