Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup executors #416

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
50ee3fb
cleanup
mouseless0x Jan 26, 2025
48e1bcb
move filterOpsAndEstimateGas to own file
mouseless0x Jan 26, 2025
24facc0
cleanup
mouseless0x Jan 26, 2025
25daacd
cleanup
mouseless0x Jan 26, 2025
255ec63
cleanup markWalletProcessed flow
mouseless0x Jan 26, 2025
e2a3202
create helpers to keep track of bundling status
mouseless0x Jan 26, 2025
8b2248d
cleanup creating bundles from mempool
mouseless0x Jan 26, 2025
e571611
create UserOperationBundle type
mouseless0x Jan 26, 2025
c51dfe2
cleanup
mouseless0x Jan 26, 2025
81a6bb0
cleanup executor bundle method
mouseless0x Jan 27, 2025
a7a1f46
cleanup replacement flow
mouseless0x Jan 27, 2025
d6f74a0
add UserOperationWithHash type
mouseless0x Jan 27, 2025
cc2254b
fix pimlico_sendUserOperationNow endpoint
mouseless0x Jan 27, 2025
3091c2f
add failedToReplaceTransaction helper
mouseless0x Jan 27, 2025
36885a2
cleanup replaceTransaction flow
mouseless0x Jan 27, 2025
7853746
cleanup
mouseless0x Jan 27, 2025
06079fb
fix build
mouseless0x Jan 27, 2025
d9fa603
get rid of UserOperationWithHash type
mouseless0x Jan 27, 2025
a2cee31
fix
mouseless0x Jan 27, 2025
a098631
revert e2e test changes
mouseless0x Jan 27, 2025
fc42a22
fix
mouseless0x Jan 27, 2025
843144e
add comments
mouseless0x Jan 27, 2025
7c9cfb4
Merge branch 'main' into cleanup-executors
mouseless0x Jan 28, 2025
584ccad
cleanup
mouseless0x Jan 28, 2025
4cc2503
fix
mouseless0x Jan 28, 2025
193081f
cleanup innerHandleOpFloor calculations
mouseless0x Jan 28, 2025
012a320
fix comment
mouseless0x Jan 28, 2025
d29434c
remove gas floor check
mouseless0x Jan 28, 2025
caa00a3
fix
mouseless0x Jan 29, 2025
fe3a37c
keep gas floor check
mouseless0x Jan 29, 2025
008a5a0
fix
mouseless0x Jan 29, 2025
a5fc67b
restore userOp with hash type
mouseless0x Jan 30, 2025
a1fcc92
use correct port
mouseless0x Jan 30, 2025
fc199f3
cleanuo
mouseless0x Jan 30, 2025
61c81d6
fix bug
mouseless0x Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/cli/config/bundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ export const compatibilityArgsSchema = z.object({
.optional()
.transform((val) => val as ApiVersion),
"balance-override": z.boolean(),
"local-gas-limit-calculation": z.boolean(),
"flush-stuck-transactions-during-startup": z.boolean(),
"fixed-gas-limit-for-estimation": z
.string()
Expand Down
7 changes: 0 additions & 7 deletions src/cli/config/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,6 @@ export const compatibilityOptions: CliCommandOptions<ICompatibilityArgsInput> =
require: true,
default: true
},
"local-gas-limit-calculation": {
description:
"Calculate the bundle transaction gas limits locally instead of using the RPC gas limit estimation",
type: "boolean",
require: true,
default: false
},
"flush-stuck-transactions-during-startup": {
description:
"Flush stuck transactions with old nonces during bundler startup",
Expand Down
10 changes: 5 additions & 5 deletions src/cli/setupServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,13 @@ const getEventManager = ({
const getExecutor = ({
mempool,
config,
senderManager,
reputationManager,
metrics,
gasPriceManager,
eventManager
}: {
mempool: MemoryMempool
config: AltoConfig
senderManager: SenderManager
reputationManager: InterfaceReputationManager
metrics: Metrics
gasPriceManager: GasPriceManager
Expand All @@ -114,7 +112,6 @@ const getExecutor = ({
return new Executor({
mempool,
config,
senderManager,
reputationManager,
metrics,
gasPriceManager,
Expand All @@ -127,6 +124,7 @@ const getExecutorManager = ({
executor,
mempool,
monitor,
senderManager,
reputationManager,
metrics,
gasPriceManager,
Expand All @@ -137,6 +135,7 @@ const getExecutorManager = ({
mempool: MemoryMempool
monitor: Monitor
reputationManager: InterfaceReputationManager
senderManager: SenderManager
metrics: Metrics
gasPriceManager: GasPriceManager
eventManager: EventManager
Expand All @@ -146,6 +145,7 @@ const getExecutorManager = ({
executor,
mempool,
monitor,
senderManager,
reputationManager,
metrics,
gasPriceManager,
Expand Down Expand Up @@ -275,7 +275,6 @@ export const setupServer = async ({
const executor = getExecutor({
mempool,
config,
senderManager,
reputationManager,
metrics,
gasPriceManager,
Expand All @@ -287,6 +286,7 @@ export const setupServer = async ({
executor,
mempool,
monitor,
senderManager,
reputationManager,
metrics,
gasPriceManager,
Expand Down Expand Up @@ -314,7 +314,7 @@ export const setupServer = async ({
})

if (config.flushStuckTransactionsDuringStartup) {
executor.flushStuckTransactions()
senderManager.flushOnStartUp()
}

const rootLogger = config.getLogger(
Expand Down
Loading