-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: update global checkpoint ts for safepoint #59210
base: master
Are you sure you want to change the base?
br: update global checkpoint ts for safepoint #59210
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59210 +/- ##
================================================
+ Coverage 73.0489% 74.5652% +1.5162%
================================================
Files 1684 1705 +21
Lines 466386 480102 +13716
================================================
+ Hits 340690 357989 +17299
+ Misses 104751 99663 -5088
- Partials 20945 22450 +1505
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
What problem does this PR solve?
Issue Number: close #59094 ref #58031
Problem Summary:
the safepoint error is skipped if the new safepoint is less than the minimal safepoint of the cluster or if occurs an error when put the new safepoint to PD.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.