Fix: a jedis client returning destination #4
Conversation
|
thanks for this, however, it's not really idiomatic in scala to use a Thanks |
|
I tried to fix using the way of error handling that you pointed out. |
| } | ||
| result.get | ||
| } |
There was a problem hiding this comment.
It's almost same as withJedisClient. Better to write as withJedisClient(jedis => body(Dress.up(jedis))).
A client has to be returned to the broken client pool, when an exception occurred.
|
removed duplicate code on @tkawachi 's suggestion, and rebased. |
| val result = Try(body(jedis)) | ||
|
|
||
| result match { | ||
| case Failure(e:JedisConnectionException) => { |
There was a problem hiding this comment.
this exception is not logged, so the client won't be aware of this event.
A client has to be returned to the broken client pool, when an exception occurred.