Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vtbackup in scheduled backups #658

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Use vtbackup in scheduled backups #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c10c0f4
Refactor GetCompletedBackup to be shared between different controllers
frouioui Jan 23, 2025
9f75193
Use Forbid as the default concurrency setting in vbs
frouioui Jan 28, 2025
0e982c7
Fix tests
frouioui Jan 28, 2025
97bed04
Run vtbackup pods instead of vtctldclient
frouioui Jan 28, 2025
73a622f
Merge remote-tracking branch 'origin/main' into use-vtbackup-in-sched…
frouioui Jan 28, 2025
460e94d
Edit tests
frouioui Jan 29, 2025
e9e1594
Fix service name length and initial backup issues
frouioui Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/crds/planetscale.com_vitessbackupschedules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ spec:
cluster:
type: string
concurrencyPolicy:
default: Forbid
enum:
- Allow
- Forbid
Expand Down
1 change: 1 addition & 0 deletions deploy/crds/planetscale.com_vitessclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ spec:
type: string
type: object
concurrencyPolicy:
default: Forbid
enum:
- Allow
- Forbid
Expand Down
4 changes: 2 additions & 2 deletions docs/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,8 +2828,8 @@ ConcurrencyPolicy
<em>(Optional)</em>
<p>ConcurrencyPolicy specifies ho to treat concurrent executions of a Job.
Valid values are:
- &ldquo;Allow&rdquo; (default): allows CronJobs to run concurrently;
- &ldquo;Forbid&rdquo;: forbids concurrent runs, skipping next run if previous run hasn&rsquo;t finished yet;
- &ldquo;Allow&rdquo;: allows CronJobs to run concurrently;
- &ldquo;Forbid&rdquo; (default): forbids concurrent runs, skipping next run if previous run hasn&rsquo;t finished yet;
- &ldquo;Replace&rdquo;: cancels currently running job and replaces it with a new one.</p>
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions docs/api/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2830,8 +2830,8 @@ <h3 id="planetscale.com/v2.VitessBackupScheduleTemplate">VitessBackupScheduleTem
<em>(Optional)</em>
<p>ConcurrencyPolicy specifies ho to treat concurrent executions of a Job.
Valid values are:
- &ldquo;Allow&rdquo; (default): allows CronJobs to run concurrently;
- &ldquo;Forbid&rdquo;: forbids concurrent runs, skipping next run if previous run hasn&rsquo;t finished yet;
- &ldquo;Allow&rdquo;: allows CronJobs to run concurrently;
- &ldquo;Forbid&rdquo; (default): forbids concurrent runs, skipping next run if previous run hasn&rsquo;t finished yet;
- &ldquo;Replace&rdquo;: cancels currently running job and replaces it with a new one.</p>
</td>
</tr>
Expand Down
5 changes: 3 additions & 2 deletions pkg/apis/planetscale/v2/vitessbackupschedule_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,12 @@ type VitessBackupScheduleTemplate struct {

// ConcurrencyPolicy specifies ho to treat concurrent executions of a Job.
// Valid values are:
// - "Allow" (default): allows CronJobs to run concurrently;
// - "Forbid": forbids concurrent runs, skipping next run if previous run hasn't finished yet;
// - "Allow": allows CronJobs to run concurrently;
// - "Forbid" (default): forbids concurrent runs, skipping next run if previous run hasn't finished yet;
// - "Replace": cancels currently running job and replaces it with a new one.
// +optional
// +kubebuilder:example="Forbid"
// +kubebuilder:default="Forbid"
ConcurrencyPolicy ConcurrencyPolicy `json:"concurrencyPolicy,omitempty"`

// AllowedMissedRuns defines how many missed run of the schedule will be allowed before giving up on finding the last job.
Expand Down
Loading