Volto form block fixes #6370

robgietema · 2024-10-03T15:09:27Z

I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
I verified there aren't other open pull requests for the same change.
I followed the guidelines in Contributing to Volto.
I succesfully ran code linting checks on my changes locally.
I succesfully ran unit tests on my changes locally.
I succesfully ran acceptance tests on my changes locally.
If needed, I added new tests for my changes.
If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

netlify · 2024-10-03T15:09:46Z

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	`9f8e339`
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/67a22261e9ffea0008462504

davisagli

Please add release notes and fix the lint errors and failing unit tests.

stevepiercy · 2024-10-17T08:49:23Z

This PR should also render its Storybook. We recently merged a PR that should fix the pull request preview build on Netlify:
#6410

The Netlify build currently fails to recognize changes in the most recent commit:
https://app.netlify.com/sites/plone-components/deploys/670fb4bff3f6740008e0d09f

This caused the object_browser widget loosing the mode and return props which got the default "multiple", "multiple" values even when "image", "single" was desired. As a consequence this broke the preview images.

stevepiercy

I reviewed only the .pot and news, both of which look good, with a couple of MyST markup enhancements and a question.

Will this PR need developer documentation? For example:

https://6.docs.plone.org/volto/development/widget.html

packages/volto/news/6370.feature

packages/volto/src/components/manage/Widgets/CheckboxGroupWidget.jsx

robgietema · 2024-12-23T22:30:07Z

I reviewed only the .pot and news, both of which look good, with a couple of MyST markup enhancements and a question.

Will this PR need developer documentation? For example:

https://6.docs.plone.org/volto/development/widget.html

The issues are fixed. The page for those widgets is about declaring widgets in the backend not the frontend so doesn't make sense to add anything on that page.

robgietema · 2024-12-23T22:35:23Z

Please add release notes and fix the lint errors and failing unit tests.

Done

Add default value to checkbox widget.

davisagli

In general this has a lot of useful improvements, but still some rough edges and missing docs.

davisagli · 2025-01-28T05:32:59Z

packages/volto/src/components/manage/Form/ModalForm.jsx

+  /**
+   * On updates caused by props change
+   * if errors from Backend come, these will be shown to their corresponding Fields
+   * also the first Tab to have any errors will be selected


This code doesn't appear to have anything to do with form errors?

davisagli · 2025-01-28T05:37:48Z

packages/volto/src/config/Blocks.jsx

@@ -346,6 +347,7 @@ const blocksConfig = {
    view: ViewVideoBlock,
    edit: EditVideoBlock,
    schema: BlockSettingsSchema,
+    blockSchema: VideoBlockSchema,


What's this for? I don't see anything about the video block in the changelog.

davisagli · 2025-01-28T05:42:08Z

packages/volto/src/helpers/FormValidation/FormValidation.jsx

+        !schema.properties[requiredField].readonly &&
+        isEmpty) ||
+      (schema.properties[requiredField]?.type === 'boolean' &&
+        formData[requiredField] !== true)


This one is a bit dangerous. It's a breaking change, and for schemas coming from the backend, required on a Boolean means it has to have a value of True or False rather than None, not that it has to be True.

davisagli · 2025-01-28T05:44:31Z

packages/volto/src/components/theme/Widgets/HiddenWidget.test.jsx

+import renderer from 'react-test-renderer';
+import HiddenWidget from './HiddenWidget';
+
+describe('TextWidget', () => {


Suggested change

describe('TextWidget', () => {

describe('HiddenWidget', () => {

davisagli · 2025-01-28T05:46:19Z

packages/volto/src/components/manage/Widgets/index.tsx

+      /* webpackChunkName: "Widgets" */ '@plone/volto/components/manage/Widgets/TimeWidget'
+    ),
+);
+


Presumably the new widgets need to be mentioned in docs somewhere?

davisagli · 2025-01-28T06:06:49Z

packages/volto/src/components/manage/Blocks/Block/BlocksForm.jsx

+    const blockConfig =
+      blocksConfig[properties[getBlocksFieldname(properties)][block]['@type']];
+
+    if (e.key === 'Enter' && !disableEnter && !blockConfig.disableEnter) {


disableEnter in blockConfig is not documented

davisagli · 2025-01-28T06:10:30Z

packages/volto/src/components/manage/Form/Form.jsx

@@ -982,6 +1002,8 @@ class Form extends Component {
                  )}
                  {map(schema.fieldsets[0].fields, (field) => (
                    <Field
+                      widgets={this.props.widgets}
+                      component={this.props.component}


Why do you pass component to the Field here and on line 949? I don't see where it is used?

davisagli · 2025-01-28T06:11:14Z

packages/volto/news/6370.feature

+Add optional widgets `config` to form component. @robgietema
+Add option to override the form component and the buttons in the form component. @robgietema
+Add option to override cancel label in form. @robgietema
+Add option to choose bewteen icon and text buttons in the form component. @robgietema


Suggested change

Add option to choose bewteen icon and text buttons in the form component. @robgietema

Add option to choose between icon and text buttons in the form component. @robgietema

davisagli · 2025-01-28T06:12:00Z

packages/volto/src/components/manage/Form/Form.jsx

@@ -272,22 +283,19 @@ class Form extends Component {
        selected: null,
      });
    }
-    if (requestError) {
+
+    if (requestError && prevProps.requestError !== requestError) {


This looks like a bugfix which isn't mentioned in the changelog.

davisagli · 2025-01-28T06:13:45Z

packages/volto/src/components/manage/Form/Form.jsx

+              title={this.props.schema.properties[err].title || err}
+              content={errors[err].join(', ')}
+            />,
+          ),


Missing in changelog?

davisagli · 2025-01-28T06:26:37Z

packages/volto/src/components/manage/Widgets/SchemaWidget.jsx

+        type: 'string',
+        title: intl.formatMessage(messages.queryParameterName),
+        description: intl.formatMessage(messages.queryParameterNameDescription),
+      },


I tried adding a queryParameterName to a field in a content type schema, but it doesn't do anything.

davisagli · 2025-01-28T06:27:42Z

packages/volto/src/components/manage/Widgets/SchemaWidget.jsx

+        type: 'string',
+        title: intl.formatMessage(messages.parentFieldSet),
+        choices: makeFieldsetList(fieldsets),
+      },


This seems to be shown even if there is only one fieldset available, which is distracting.

davisagli · 2025-01-28T06:28:20Z

packages/volto/src/components/manage/Widgets/SchemaWidget.jsx

+        placeholder: {
+          type: 'string',
+          title: intl.formatMessage(messages.placeholder),
+        },


I tried adding a placeholder to a text field in a content type schema, but it didn't show up when I edited the content type.

davisagli requested changes Oct 4, 2024

View reviewed changes

davisagli requested a review from sneridagh October 4, 2024 00:59

robgietema force-pushed the volto-form-block-fixes branch 2 times, most recently from 6d9bc8a to be53373 Compare November 5, 2024 12:55

robgietema force-pushed the volto-form-block-fixes branch from 988b47e to dd5a050 Compare December 20, 2024 18:55

robgietema and others added 23 commits December 20, 2024 11:55

Volto form block fixes.

8028feb

Add default value in schema editor.

43c107c

Add hidden widget.

87ef091

Add static text field.

dde6545

Add field factory utilities.

314da4f

Added extra widgets.

19df4be

Add disable enter setting.

b3abf4f

Fix translations.

7f210eb

Add placeholder and id editing.

59d9f74

Add text button option to forms.

57e76b4

Fix number field.

4fd40f6

Add file size and allowed types to file widget.

cf63ae6

Add default values for date fields.

bb23416

Add query parameter name.

a8a8795

Fix linting.

c2e4479

Add snapshots.

d18e93a

Revert number fix.

2a55b10

Add option for custom widgets in schemawidget.

cbf4e4e

Add support for custom form and button component in forms.

7f25133

Create unique slug for new fields in schemawidget.

9bdda5f

Fix broken call to getWidgetPropsFromTaggedValues

c8b7c94

This caused the object_browser widget loosing the mode and return props which got the default "multiple", "multiple" values even when "image", "single" was desired. As a consequence this broke the preview images.

Modal form improvements.

4bf6bb3

Fix static text widget label.

bce95d2

robgietema added 8 commits December 20, 2024 11:55

Add sorting to types in schemawidget.

b7fe873

Show field type on edit in schemawidget.

260f50f

Set default field type in add field in schema widet.

6fa86f1

Add classname to edit and add field modal in schemawidget.

2e796d7

Classname fix for schemawidget modal.

c1d16de

Fix modal title in schemawidget.

ee5a224

Add support for formdata change in modal form.

2f55d58

Add changelog.

dc2c6a4

robgietema force-pushed the volto-form-block-fixes branch from dd5a050 to dc2c6a4 Compare December 20, 2024 18:55

stevepiercy requested changes Dec 21, 2024

View reviewed changes

robgietema added 6 commits December 23, 2024 10:04

Fix getVocabulary import.

29f412d

Fix schemawidget test missing classname.

68f7c1f

Fix imports.

52adc1c

Fix imports.

5b7d3f5

Remove unused snapshots.

5fa314e

Set selector more specific to change factory in the schema widget.

5880acb

robgietema added 4 commits January 15, 2025 16:49

Make checkbox required to be checked if required is set.

f793261

Add default value to checkbox widget.

Add schema enhancers to form validation.

49a797d

Add schema validators.

8524574

Only apply enhancers in form validation if schema is supplied.

4d0ec26

davisagli requested changes Jan 28, 2025

View reviewed changes

davisagli added the 04 type: enhancement label Jan 29, 2025

robgietema added 3 commits January 29, 2025 18:46

Typo.

5c691d1

Fix required fields when changing the shortname.

cd77295

Fix object browser when slate is used in a popup.

9f8e339

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Volto form block fixes #6370

Volto form block fixes #6370

robgietema commented Oct 3, 2024 •

edited

Loading

netlify bot commented Oct 3, 2024 •

edited

Loading

davisagli left a comment •

edited

Loading

stevepiercy commented Oct 17, 2024

stevepiercy left a comment

robgietema commented Dec 23, 2024

robgietema commented Dec 23, 2024

davisagli left a comment

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

davisagli Jan 28, 2025

	describe('TextWidget', () => {
	describe('HiddenWidget', () => {

	Add option to choose bewteen icon and text buttons in the form component. @robgietema
	Add option to choose between icon and text buttons in the form component. @robgietema

Volto form block fixes #6370

Are you sure you want to change the base?

Volto form block fixes #6370

Conversation

robgietema commented Oct 3, 2024 • edited Loading

netlify bot commented Oct 3, 2024 • edited Loading

✅ Deploy Preview for plone-components canceled.

davisagli left a comment • edited Loading

Choose a reason for hiding this comment

stevepiercy commented Oct 17, 2024

stevepiercy left a comment

Choose a reason for hiding this comment

robgietema commented Dec 23, 2024

robgietema commented Dec 23, 2024

davisagli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robgietema commented Oct 3, 2024 •

edited

Loading

netlify bot commented Oct 3, 2024 •

edited

Loading

davisagli left a comment •

edited

Loading