Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDL3, bringing in support for Windows Ink pen input, and enable it on desktop platforms once again #6511

Merged
merged 6 commits into from
Jan 28, 2025

Merge branch 'master' into update-SDL3

b33e6a6
Select commit
Loading
Failed to load commit list.
Merged

Update SDL3, bringing in support for Windows Ink pen input, and enable it on desktop platforms once again #6511

Merge branch 'master' into update-SDL3
b33e6a6
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jan 28, 2025 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Supersedes #6484 Incomplete
Closes ppy/osu#28254 Incomplete
Closes #6291 Incomplete
Closes ppy/osu#28223 Incomplete
Closes ppy/osu#30641 Incomplete
Resolves the soft dependency for #6498 (comment) Incomplete
ppy/SDL3-CS#197 Completed
ppy/SDL3-CS#200 Completed
SDL3-CS release Completed
ppy/osu#28222 Incomplete
ppy/osu#28279 Incomplete
ppy/osu#28259 Incomplete
hover not broken, touch taps while dragging or hovering pen still have latency Incomplete
during gameplay (not menu), dragging the pen leaves the cursor motionless where you started the drag, unless you started dragging on a circle (a bit inconsistently) Incomplete
hover not broken, touch taps while dragging or hovering pen still have latency Incomplete
dragging the pen causes the cursor to lag (as in its position updates at a lower frequency) Incomplete
touch device mod flickers off and on (mostly on) while dragging the pen (seen in song select) Incomplete
hover not broken, touch taps while dragging or hovering pen still have latency
^ best so far! Incomplete
hover not broken Incomplete
touch taps while dragging or hovering the pen put the cursor where you tap (can't play at all) Incomplete
dragging the pen causes the cursor to lag (as in its position updates at a lower frequency) Incomplete
touch device mod flickers off and on (mostly on) while dragging the pen (seen in song select) Incomplete
works ok, same as test 3 in my previous comment Incomplete
playing with only the pen doesn't activate TD, while pen + touch does Incomplete
looks like i didn't have mouse buttons disabled, so i miss the first note when dragging the pen and tapping for the first time (normally happens with keyboard + pen but not with two-hand touch) Incomplete