Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit via GitHub Actions #131

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Run pre-commit via GitHub Actions #131

merged 3 commits into from
Nov 7, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Nov 7, 2024

This PR does the following things:

  1. Removes the Action to check formatting via clang-format, because it is now checked by directly running pre-commit. This increases maintainability as the clang-format version is now defined at only one place, the pre-commit config file.
  2. Runs pre-commit via an Action, which checks formatting and also other things that are included in the pre-commit checks
  3. The Ubuntu build Action now runs only once in a pull request to the main or develop branches. Earlier there used to always be two runs per push via a pull request.

@IshaanDesai IshaanDesai marked this pull request as ready for review November 7, 2024 13:15
@IshaanDesai IshaanDesai self-assigned this Nov 7, 2024
@IshaanDesai IshaanDesai requested a review from MakisH November 7, 2024 13:16
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for tidying up!

@IshaanDesai IshaanDesai merged commit 8eb1d43 into develop Nov 7, 2024
3 checks passed
@IshaanDesai IshaanDesai deleted the run-checks branch November 7, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants